Single tap on the previous selection should toggle the toolbar on iOS… #108913

Renzo-Olivares · 2022-08-03T19:47:09Z

This change continues @doppio work from #95644.

On iOS, a single tap on the previous selection should toggle the toolbar. This change accomplishes that, and also when a tap occurs within a previous selection, the selection should stay the same. For example if there is a non collapsed selection, and we tap on it, this should toggle the toolbar and keep the selection. Previously the selection would move to the word edge closest to the tapped position.

iOS toggle toolbar on non-collapsed selection	iOS toggle toolbar on collapsed selection

Flutter Before	Flutter After

Fixes b/173627308 and #48434

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

… a single tap on within the previous selection should not change it

Renzo-Olivares · 2022-08-04T21:06:38Z

cc: @chunhtai if you have any thoughts on this solution since global selection should probably do something similar.

justinmc

LGTM 👍 I think you and I had nearly the same exact approach.

packages/flutter/lib/src/cupertino/text_field.dart

justinmc · 2022-08-10T20:25:25Z

packages/flutter/lib/src/widgets/text_selection.dart

+    );
+
+    return renderEditable.selection!.start < textPosition.offset
+        && renderEditable.selection!.end > textPosition.offset;


Will this work if the selection is collapsed?

Talked offline about not handling ==.

The reason I didn't handle the == case is because say we have hello world with world selected, and we want to tap at the edge of world to collapse the selection and move the cursor to the end of the field. Because we handle == we can't do that and the selection stays on world.

packages/flutter/test/cupertino/text_field_test.dart

packages/flutter/test/material/text_field_test.dart

…r on iOS… (flutter/flutter#108913)

* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461) * a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462) * 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466) * a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401) * dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428) * 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481) * 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472) * fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913) * 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482) * 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483) * 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488) * c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490) * 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493) * d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505) * 97901da Cleaner test.dart output. (flutter/flutter#109206) * fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509) * 5fcd9c2 Update README.md (flutter/flutter#109506) * 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753) * ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518) * 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524) * 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526) * 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532) * 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536) * 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543) * 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548) * 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552) * c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)

ChristianEdwardPadilla · 2022-09-15T14:07:51Z

Can we roll this back? Seems it is causing crashes: #111660.

…r on iOS… (#108913)" This reverts commit fe2fc8d.

…r on iOS #108913" (#111995)

…e toolbar on iOS flutter#108913" (flutter#111995)" This reverts commit 4abe6fd.

* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461) * a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462) * 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466) * a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401) * dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428) * 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481) * 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472) * fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913) * 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482) * 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483) * 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488) * c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490) * 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493) * d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505) * 97901da Cleaner test.dart output. (flutter/flutter#109206) * fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509) * 5fcd9c2 Update README.md (flutter/flutter#109506) * 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753) * ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518) * 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524) * 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526) * 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532) * 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536) * 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543) * 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548) * 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552) * c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)

Renzo Olivares added 2 commits August 3, 2022 12:38

Single tap on the previous selection should toggle the toolbar on iOS…

795f61e

… a single tap on within the previous selection should not change it

remove erroneous file

b43c5a2

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 3, 2022

Renzo Olivares added 4 commits August 3, 2022 12:48

hide toolbar for android and fuchsia as normal

11a9cae

fix material tests

72a5806

fix text_selection_test.dart

74df6b9

fix cupertino text field tests

057d165

flutter-dashboard bot added the f: cupertino flutter/packages/flutter/cupertino repository label Aug 3, 2022

Renzo Olivares added 5 commits August 3, 2022 14:33

fix analyzer

6c1b4d2

Merge branch 'master' of github.com:flutter/flutter into single-tap-ios

0ba1aee

try to fix cupertino test on web

fcf9ab5

fix broken web tests, context menus are rendered by web not flutter"

237fd1f

add tests

9846b8e

Renzo-Olivares marked this pull request as ready for review August 4, 2022 20:32

Renzo-Olivares requested a review from justinmc August 4, 2022 20:32

make analyzer happy

a189254

Renzo-Olivares requested a review from LongCatIsLooong August 4, 2022 20:57

justinmc approved these changes Aug 10, 2022

View reviewed changes

justinmc mentioned this pull request Aug 10, 2022

Single tap should show toolbar on iOS #109267

Closed

address nits

ca6d610

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2022

auto-submit bot merged commit fe2fc8d into flutter:master Aug 13, 2022

This was referenced Aug 13, 2022

Roll Flutter from c91b481263da to 8a55c366eb2d (50 revisions) flutter/packages#2456

Closed

Roll Flutter from 9ad052a57e0f to 8a55c366eb2d (49 revisions) flutter/plugins#6241

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

0426b5e

…r on iOS… (flutter/flutter#108913)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 13, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

ec2e413

…r on iOS… (flutter/flutter#108913)

engine-flutter-autoroll mentioned this pull request Aug 13, 2022

Roll Flutter from 9ad052a57e0f to 8a55c366eb2d (49 revisions) flutter/plugins#6242

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

36c9559

…r on iOS… (flutter/flutter#108913)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

bf4b022

…r on iOS… (flutter/flutter#108913)

This was referenced Aug 15, 2022

Roll Flutter from c91b481263da to 2bce10866592 (61 revisions) flutter/packages#2463

Closed

Roll Flutter from 9ad052a57e0f to 2bce10866592 (60 revisions) flutter/plugins#6269

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

191a595

…r on iOS… (flutter/flutter#108913)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

ac75af3

…r on iOS… (flutter/flutter#108913)

This was referenced Aug 15, 2022

Roll Flutter from c91b481263da to 97d9a2f0d601 (62 revisions) flutter/packages#2464

Closed

Roll Flutter from 9ad052a57e0f to 97d9a2f0d601 (61 revisions) flutter/plugins#6270

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

b574966

…r on iOS… (flutter/flutter#108913)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

067b367

…r on iOS… (flutter/flutter#108913)

This was referenced Aug 15, 2022

Roll Flutter from c91b481263da to 458d618ad693 (63 revisions) flutter/packages#2465

Closed

Roll Flutter from 9ad052a57e0f to 458d618ad693 (62 revisions) flutter/plugins#6273

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

ca99f53

…r on iOS… (flutter/flutter#108913)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

ebfb0e5

…r on iOS… (flutter/flutter#108913)

This was referenced Aug 15, 2022

Roll Flutter from a0f1c670ed90 to c873c2100ad7 (27 revisions) flutter/packages#2466

Merged

Roll Flutter from a0f1c670ed90 to c873c2100ad7 (27 revisions) flutter/plugins#6275

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

5b45557

…r on iOS… (flutter/flutter#108913)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022

fe2fc8d Single tap on the previous selection should toggle the toolba…

503e723

…r on iOS… (flutter/flutter#108913)

ChristianEdwardPadilla mentioned this pull request Sep 15, 2022

Forced Null Dereference causing crash in editableTextState #111660

Closed

godofredoc added a commit that referenced this pull request Sep 15, 2022

Revert "Single tap on the previous selection should toggle the toolba…

1520517

…r on iOS… (#108913)" This reverts commit fe2fc8d.

godofredoc mentioned this pull request Sep 15, 2022

Revert "Single tap on the previous selection should toggle the toolbar on iOS…" #111662

Merged

Renzo-Olivares mentioned this pull request Sep 20, 2022

Reland "Single tap on the previous selection should toggle the toolbar on iOS #108913" #111995

Merged

8 tasks

auto-submit bot pushed a commit that referenced this pull request Oct 17, 2022

Reland "Single tap on the previous selection should toggle the toolba…

4abe6fd

…r on iOS #108913" (#111995)

Renzo-Olivares pushed a commit to Renzo-Olivares/flutter that referenced this pull request Nov 28, 2022

Revert "Reland "Single tap on the previous selection should toggle th…

29ce977

…e toolbar on iOS flutter#108913" (flutter#111995)" This reverts commit 4abe6fd.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Single tap on the previous selection should toggle the toolbar on iOS… #108913

Single tap on the previous selection should toggle the toolbar on iOS… #108913

Uh oh!

Renzo-Olivares commented Aug 3, 2022 •

edited

Loading

Uh oh!

Renzo-Olivares commented Aug 4, 2022

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

justinmc Aug 10, 2022

Uh oh!

Renzo-Olivares Aug 12, 2022

Uh oh!

Uh oh!

Uh oh!

ChristianEdwardPadilla commented Sep 15, 2022

Uh oh!

Uh oh!

Single tap on the previous selection should toggle the toolbar on iOS… #108913

Single tap on the previous selection should toggle the toolbar on iOS… #108913

Uh oh!

Conversation

Renzo-Olivares commented Aug 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Renzo-Olivares commented Aug 4, 2022

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Aug 12, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ChristianEdwardPadilla commented Sep 15, 2022

Uh oh!

Uh oh!

Renzo-Olivares commented Aug 3, 2022 •

edited

Loading