Skip to content

Fix InputDecoration helper/error padding is not compliant #176353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

Fix InputDecoration helper/error padding is not compliant #176353

merged 2 commits into from
Oct 8, 2025
+105 −7

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Oct 1, 2025 •
edited by QuncCccccc
Loading

Description

This PR fixes the InputDecoration helper/error padding.
When a counter is defined, this PR fixes the width of the gap between helper/error and the counter.

M3 specs:

Screenshot 2025-10-07 at 5 36 05 PM

Before

image

After

image

Related Issue

Fixes InputDecoration helper/error end padding is not compliant with M3 spec

Tests

  • Adds 2 tests. One to verify the new padding. Another to verify the change in intrinsic height calculation. This second test does not fail without the PR but it would have failed if the PR changes only the padding and did not update the intrinsic height logic.
  • Updates 1 test related to the gap between error/helper and counter.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 1, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 1, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with InputDecoration where the helper/error text padding was not compliant with Material 3 specifications. The changes in _RenderDecoration correctly adjust the constraints for the subtext to account for start and end padding, as well as the input gap. The intrinsic height calculation is also updated to be consistent with these padding changes. Additionally, new tests are added to verify the correct padding and to ensure the intrinsic height calculation doesn't cause unintended layout changes. An existing test is also updated to assert the correct gap as per the M3 spec. The changes look good and effectively fix the reported issue.

@bleroux
Copy link
Contributor Author

bleroux commented Oct 1, 2025

@QuncCccccc @victorsanni Thank you to review this PR. I assigned you as reviewers because you reviewed #175706.
This PR will break many Google tests, let me know if some failures are not expected.

@victorsanni
Copy link
Contributor

I approved, this should trigger the google testing run.

@bleroux bleroux requested a review from victorsanni October 3, 2025 19:55
@victorsanni
Copy link
Contributor

Looking at the test failures, I see that sometimes the error text gets ellipsized after a space. So for example it changes from "Hello wor..." to "Hello ...". The unusual space after the before the ellipses makes it look buggy. Is this expected?

victorsanni
victorsanni approved these changes Oct 4, 2025
View reviewed changes
Copy link
Contributor

@victorsanni victorsanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the google testing image diffs, they all look expected from these changes.

QuncCccccc
QuncCccccc approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement! I added a screenshot to show the M3 specs in the PR description. Just wanted to attach a reference as sometimes the specs changes:) Also checked all the Scuba diffs and they all look expected.

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Oct 8, 2025
Merged via the queue into flutter:master with commit 8c4e105 Oct 8, 2025
78 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025
@bleroux bleroux deleted the fix_InputDecoration_helper_error_padding branch October 8, 2025 06:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025
@engine-flutter-autoroll
8c4e1057e Fix InputDecoration helper/error padding is not compliant (f…
13ebccc 
…lutter/flutter#176353)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025
@engine-flutter-autoroll
8c4e1057e Fix InputDecoration helper/error padding is not compliant (f…
6fdc6f0 
…lutter/flutter#176353)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025
@engine-flutter-autoroll
8c4e1057e Fix InputDecoration helper/error padding is not compliant (f…
66c21ec 
…lutter/flutter#176353)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 8, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025
@engine-flutter-autoroll
8c4e1057e Fix InputDecoration helper/error padding is not compliant (f…
90f519a 
…lutter/flutter#176353)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025
@engine-flutter-autoroll
8c4e1057e Fix InputDecoration helper/error padding is not compliant (f…
a625332 
…lutter/flutter#176353)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 8, 2025
@engine-flutter-autoroll
Roll Flutter from 908012d58baa to e11e2c11288b (39 revisions) (#10192)
2ed8f68 
Roll Flutter from 908012d58baa to e11e2c11288b (39 revisions)

flutter/flutter@908012d...e11e2c1

2025-10-08 vegorov@google.com Configure FfiNative resolver on dart:io (flutter/flutter#176621)
2025-10-08 fluttergithubbot@gmail.com Marks Linux_pixel_7pro service_extensions_test to be unflaky (flutter/flutter#176700)
2025-10-08 matt.boetger@gmail.com Keyboard Animation Fix (flutter/flutter#176418)
2025-10-08 34465683+rkishan516@users.noreply.github.com Feat: Add carousel view builder (flutter/flutter#172837)
2025-10-08 engine-flutter-autoroll@skia.org Roll Skia from d10a0d877ff4 to ea7cdbc6b986 (15 revisions) (flutter/flutter#176686)
2025-10-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJr3my9C6TwYWPygi... to xrIAL91ngrd-wNr9S... (flutter/flutter#176682)
2025-10-08 bruno.leroux@gmail.com Fix InputDecoration helper/error padding is not compliant (flutter/flutter#176353)
2025-10-08 sokolovskyi.konstantin@gmail.com Fix PopupMenu does not update when PopupMenuTheme in Theme changes. (flutter/flutter#175513)
2025-10-07 iinozemtsev@google.com Roll Dart SDK to 3.10.0-290.1.beta (flutter/flutter#176629)
2025-10-07 bkonyi@google.com [ Tool ] Output `app.dtd` and `app.devTools` in machine mode (flutter/flutter#176655)
2025-10-07 15619084+vashworth@users.noreply.github.com Rename UIScene integration test projects and fix Xcode compatibility (flutter/flutter#176635)
2025-10-07 21270878+elliette@users.noreply.github.com Selecting an implementation widget with the on-device inspector opens the code location for the nearest project widget (flutter/flutter#176530)
2025-10-07 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateInputBorder` (flutter/flutter#176386)
2025-10-07 34871572+gmackall@users.noreply.github.com Make it clear that you need to install clangd in VSCode intellisense c++ config (flutter/flutter#176609)
2025-10-07 paulberry@google.com Bump the customer tests to pick up an update to Zulip's tests. (flutter/flutter#176463)
2025-10-07 engine-flutter-autoroll@skia.org Roll Packages from d3ef88b to 8ca6416 (2 revisions) (flutter/flutter#176633)
2025-10-07 15619084+vashworth@users.noreply.github.com Add fallback for 'scene:willConnectToSession:options' (flutter/flutter#176580)
2025-10-07 engine-flutter-autoroll@skia.org Roll Skia from d09786dfb854 to d10a0d877ff4 (11 revisions) (flutter/flutter#176616)
2025-10-07 bkonyi@google.com [ Widget Preview ] Rework UI and theming (flutter/flutter#176581)
2025-10-07 15619084+vashworth@users.noreply.github.com Handle FlutterEngine registration when embedded in Multi-Scene apps (flutter/flutter#176490)
2025-10-07 robert.ancell@canonical.com Fix code style in Linux embedder template (flutter/flutter#176256)
2025-10-07 15619084+vashworth@users.noreply.github.com Add tooling to migrate to UIScene (flutter/flutter#176427)
2025-10-06 danny@tuppeny.com Bump customer tests.version to 986c4326b4e4bb4e37bc963c2cc2aaa10b943859 (flutter/flutter#176594)
2025-10-06 43959652+TDuffinNTU@users.noreply.github.com Fix typo in pages.dart (flutter/flutter#176438)
2025-10-06 34465683+rkishan516@users.noreply.github.com Fix: Update anchorRect for overlayBuilder when anchor moves (flutter/flutter#169814)
2025-10-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Zm6K_3gP3VCaMy9rH... to jJr3my9C6TwYWPygi... (flutter/flutter#176591)
2025-10-06 eternalkaif@gmail.com Fix deprecated configureStatusBarForFullscreenFlutterExperience for Android 15+ (flutter/flutter#175501)
2025-10-06 30870216+gaaclarke@users.noreply.github.com updates docs for flutter engine footprint (flutter/flutter#176217)
2025-10-06 bkonyi@google.com [ Widget Preview ] Fix `WidgetInspectorService` override (flutter/flutter#176550)
2025-10-06 bruno.leroux@gmail.com Fix NavigatorBar lacks visual feedback (flutter/flutter#175182)
2025-10-06 engine-flutter-autoroll@skia.org Roll Packages from e401aeb to d3ef88b (4 revisions) (flutter/flutter#176582)
2025-10-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 898380a41c90 to 6b0193498f09 (2 revisions) (flutter/flutter#176576)
2025-10-06 engine-flutter-autoroll@skia.org Roll Skia from bc7cf194f4ee to d09786dfb854 (1 revision) (flutter/flutter#176577)
2025-10-06 jason-simmons@users.noreply.github.com Roll vulkan-deps to a9e2ca3b (flutter/flutter#176322)
2025-10-06 15619084+vashworth@users.noreply.github.com Add an AppDelegate callback for implicit FlutterEngines (flutter/flutter#176240)
2025-10-06 engine-flutter-autoroll@skia.org Roll Skia from 45191c22b15c to bc7cf194f4ee (2 revisions) (flutter/flutter#176572)
2025-10-06 bkonyi@google.com [ Widget Preview ] Fix type error when retrieving flags from persistent preferences (flutter/flutter#176546)
2025-10-06 engine-flutter-autoroll@skia.org Roll Skia from 1fd0ca1f2120 to 45191c22b15c (3 revisions) (flutter/flutter#176556)
2025-10-05 engine-flutter-autoroll@skia.org Roll Dart SDK from 016a8c0045fd to 898380a41c90 (1 revision) (flutter/flutter#176549)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

@victorsanni victorsanni victorsanni approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

Google Testing Queue
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

InputDecoration helper/error end padding is not compliant with M3 spec

3 participants

@bleroux @victorsanni @QuncCccccc