Add fallback for 'scene:willConnectToSession:options' #176580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-ios
github-actions
bot
removed
the
tool
LongCatIsLooong
approved these changes
Oct 6, 2025
| self.sceneWillConnectEventHandledByPlugin = YES; | ||
| } | ||
|
|
||
| if (!self.sceneWillConnectEventHandledByPlugin) { |
There was a problem hiding this comment.
Once set this flag seems to never resets back to NO. Just want to make sure that we have the guarantee that each FlutterPluginSceneLifeCycleDelegate can only be associated with one scene and thus will never receive a second willConnect event?
There was a problem hiding this comment.
That is my understanding, yeah. If the scene is destroyed, for example, a new FlutterSceneDelegate and therefore FlutterPluginSceneLifeCycleDelegate is created and will receive a new willConnect event
vashworth
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/176580, because - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
vashworth
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/176580, because - The status or check suite Mac tool_integration_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
vashworth
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/176580, because - The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
vashworth
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/176580, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
vashworth
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2025
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Oct 7, 2025
This adds an application lifecycle event fallback for when the app has migrated to UIScene but the plugin has not. So if the app has migrated to UIScene and receives the `scene:willConnectToSession:options` event, if no other plugins process the event, it'll attempt to use `application:didFinishLaunchingWithOptions` event if there are meaningful launch arguments. This is a best attempt and may not cover all use cases. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Oct 7, 2025
This adds an application lifecycle event fallback for when the app has migrated to UIScene but the plugin has not. So if the app has migrated to UIScene and receives the `scene:willConnectToSession:options` event, if no other plugins process the event, it'll attempt to use `application:didFinishLaunchingWithOptions` event if there are meaningful launch arguments. This is a best attempt and may not cover all use cases. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 8, 2025
Roll Flutter from 908012d58baa to e11e2c11288b (39 revisions) flutter/flutter@908012d...e11e2c1 2025-10-08 vegorov@google.com Configure FfiNative resolver on dart:io (flutter/flutter#176621) 2025-10-08 fluttergithubbot@gmail.com Marks Linux_pixel_7pro service_extensions_test to be unflaky (flutter/flutter#176700) 2025-10-08 matt.boetger@gmail.com Keyboard Animation Fix (flutter/flutter#176418) 2025-10-08 34465683+rkishan516@users.noreply.github.com Feat: Add carousel view builder (flutter/flutter#172837) 2025-10-08 engine-flutter-autoroll@skia.org Roll Skia from d10a0d877ff4 to ea7cdbc6b986 (15 revisions) (flutter/flutter#176686) 2025-10-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJr3my9C6TwYWPygi... to xrIAL91ngrd-wNr9S... (flutter/flutter#176682) 2025-10-08 bruno.leroux@gmail.com Fix InputDecoration helper/error padding is not compliant (flutter/flutter#176353) 2025-10-08 sokolovskyi.konstantin@gmail.com Fix PopupMenu does not update when PopupMenuTheme in Theme changes. (flutter/flutter#175513) 2025-10-07 iinozemtsev@google.com Roll Dart SDK to 3.10.0-290.1.beta (flutter/flutter#176629) 2025-10-07 bkonyi@google.com [ Tool ] Output `app.dtd` and `app.devTools` in machine mode (flutter/flutter#176655) 2025-10-07 15619084+vashworth@users.noreply.github.com Rename UIScene integration test projects and fix Xcode compatibility (flutter/flutter#176635) 2025-10-07 21270878+elliette@users.noreply.github.com Selecting an implementation widget with the on-device inspector opens the code location for the nearest project widget (flutter/flutter#176530) 2025-10-07 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateInputBorder` (flutter/flutter#176386) 2025-10-07 34871572+gmackall@users.noreply.github.com Make it clear that you need to install clangd in VSCode intellisense c++ config (flutter/flutter#176609) 2025-10-07 paulberry@google.com Bump the customer tests to pick up an update to Zulip's tests. (flutter/flutter#176463) 2025-10-07 engine-flutter-autoroll@skia.org Roll Packages from d3ef88b to 8ca6416 (2 revisions) (flutter/flutter#176633) 2025-10-07 15619084+vashworth@users.noreply.github.com Add fallback for 'scene:willConnectToSession:options' (flutter/flutter#176580) 2025-10-07 engine-flutter-autoroll@skia.org Roll Skia from d09786dfb854 to d10a0d877ff4 (11 revisions) (flutter/flutter#176616) 2025-10-07 bkonyi@google.com [ Widget Preview ] Rework UI and theming (flutter/flutter#176581) 2025-10-07 15619084+vashworth@users.noreply.github.com Handle FlutterEngine registration when embedded in Multi-Scene apps (flutter/flutter#176490) 2025-10-07 robert.ancell@canonical.com Fix code style in Linux embedder template (flutter/flutter#176256) 2025-10-07 15619084+vashworth@users.noreply.github.com Add tooling to migrate to UIScene (flutter/flutter#176427) 2025-10-06 danny@tuppeny.com Bump customer tests.version to 986c4326b4e4bb4e37bc963c2cc2aaa10b943859 (flutter/flutter#176594) 2025-10-06 43959652+TDuffinNTU@users.noreply.github.com Fix typo in pages.dart (flutter/flutter#176438) 2025-10-06 34465683+rkishan516@users.noreply.github.com Fix: Update anchorRect for overlayBuilder when anchor moves (flutter/flutter#169814) 2025-10-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Zm6K_3gP3VCaMy9rH... to jJr3my9C6TwYWPygi... (flutter/flutter#176591) 2025-10-06 eternalkaif@gmail.com Fix deprecated configureStatusBarForFullscreenFlutterExperience for Android 15+ (flutter/flutter#175501) 2025-10-06 30870216+gaaclarke@users.noreply.github.com updates docs for flutter engine footprint (flutter/flutter#176217) 2025-10-06 bkonyi@google.com [ Widget Preview ] Fix `WidgetInspectorService` override (flutter/flutter#176550) 2025-10-06 bruno.leroux@gmail.com Fix NavigatorBar lacks visual feedback (flutter/flutter#175182) 2025-10-06 engine-flutter-autoroll@skia.org Roll Packages from e401aeb to d3ef88b (4 revisions) (flutter/flutter#176582) 2025-10-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 898380a41c90 to 6b0193498f09 (2 revisions) (flutter/flutter#176576) 2025-10-06 engine-flutter-autoroll@skia.org Roll Skia from bc7cf194f4ee to d09786dfb854 (1 revision) (flutter/flutter#176577) 2025-10-06 jason-simmons@users.noreply.github.com Roll vulkan-deps to a9e2ca3b (flutter/flutter#176322) 2025-10-06 15619084+vashworth@users.noreply.github.com Add an AppDelegate callback for implicit FlutterEngines (flutter/flutter#176240) 2025-10-06 engine-flutter-autoroll@skia.org Roll Skia from 45191c22b15c to bc7cf194f4ee (2 revisions) (flutter/flutter#176572) 2025-10-06 bkonyi@google.com [ Widget Preview ] Fix type error when retrieving flags from persistent preferences (flutter/flutter#176546) 2025-10-06 engine-flutter-autoroll@skia.org Roll Skia from 1fd0ca1f2120 to 45191c22b15c (3 revisions) (flutter/flutter#176556) 2025-10-05 engine-flutter-autoroll@skia.org Roll Dart SDK from 016a8c0045fd to 898380a41c90 (1 revision) (flutter/flutter#176549) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an application lifecycle event fallback for when the app has migrated to UIScene but the plugin has not. So if the app has migrated to UIScene and receives the
scene:willConnectToSession:optionsevent, if no other plugins process the event, it'll attempt to useapplication:didFinishLaunchingWithOptionsevent if there are meaningful launch arguments.This is a best attempt and may not cover all use cases.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.