Skip to content

Ensure that assumed formatting of properties file is correct #29528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 18, 2019

Description

We've seen several user reports of an exception in this method. Currently we assume that the format is exactly key = value, but it is possible this has changed or users files are corrupted. Add a defensive check to ensure we return a reasonable error if we don't find the desired property instead of crashing.

Related Issues

Fixes #29486

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 18, 2019
@jonahwilliams jonahwilliams merged commit 75c50da into flutter:master Mar 18, 2019
@jonahwilliams jonahwilliams deleted the fix_ndk_version branch March 18, 2019 17:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in findNdkMajorVersion
4 participants