Skip to content

Introduce --report-timings flag for flutter build aot command. #30032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2019

Conversation

mraleph
Copy link
Member

@mraleph mraleph commented Mar 27, 2019

Introduce --report-timings flag for flutter build aot command.

This flag makes flutter build aot report timings for substeps (e.g.
frontend compilation and gen_snapshot) in a machine readable form.

Previously our tools for continuous performance tracking attempted to
parse verbose output of flutter build aot -v and derive timings
from it - but this is extremely fragile.

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@mraleph
Copy link
Member Author

mraleph commented Mar 27, 2019

/fyi @aam

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 27, 2019
@mraleph mraleph merged commit 01e3496 into flutter:master Apr 3, 2019
@mraleph mraleph deleted the introduct-report-timings branch April 3, 2019 10:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants