Skip to content

Add semanticsLabel parameter to TextSpan #30837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 10, 2019

Description

This allows customizing the semantics label when using RichText/Spans per span.

Related Issues

Fixes #30636

Tests

I added the following tests:

  • recognizers split semantic nodes with text span labels
  • semantics configuration handles TextSpans with semanticsLabels
  • TextSpan toPlainText
  • TextSpan toPlainText with semanticsLabel

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jonahwilliams jonahwilliams changed the title Add semanticsLabel parameter to text span Add semanticsLabel parameter to TextSpan Apr 10, 2019
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit f66ee3e into flutter:master Apr 10, 2019
@jonahwilliams jonahwilliams deleted the add_semantic_label_text_span branch April 10, 2019 19:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom semantics of TextSpan for Android Talkback
3 participants