Add more context to flutter create sample #31434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
reviewed
Apr 22, 2019
| @@ -91,7 +91,8 @@ class CreateCommand extends FlutterCommand { | |||
| abbr: 's', | |||
| help: 'Specifies the Flutter code sample to use as the main.dart for an application. Implies ' | |||
| '--template=app. The value should be the sample ID of the desired sample from the API ' | |||
| 'documentation website (http://docs.flutter.io).', | |||
| 'documentation website (http://docs.flutter.dev). An example can be found at ' | |||
| 'https://master-api.flutter.dev/flutter/widgets/SingleChildScrollView-class.html', | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
That doesn't have the sample code section yet
There was a problem hiding this comment.
I see. LGTM. Maybe create some issue that reminds us to change back to "api.flutter.dev" once the sample code is there.
liyuqian
approved these changes
Apr 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to a documentation page that contains a sample.
Related Issues
Fixes #28474