Add local overrides to testbed and provide more defaults #33264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
added
the
tool
zanderso
reviewed
May 23, 2019
zanderso
reviewed
May 28, 2019
| OutputPreferences: () => OutputPreferences(showColor: false), | ||
| OperatingSystemUtils: () => MockOperatingSystemUtils(), | ||
| Usage: () => MockUsage(), | ||
| TimeoutConfiguration: () => const TimeoutConfiguration(), |
There was a problem hiding this comment.
Removed, it is not needed
| final Map<Type, Generator> _testbedDefaults = <Type, Generator>{ | ||
| FileSystem: () => MemoryFileSystem(), | ||
| Logger: () => BufferLogger(), | ||
| DeviceManager: () => MockDeviceManager(), |
There was a problem hiding this comment.
This list needs some comments describing how its membership is decided. What is the procedure for deciding that a mock should be in this defaults list?
There was a problem hiding this comment.
Added a standard criteria and removed those that did not fit. Also documented the reason for each current defaults inclusion
zanderso
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow providing overrides to a single test run and add more defaults to the overrides.