Skip to content

Reland: use flutter features for web and desktop #36699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 22, 2019

Conversation

jonahwilliams
Copy link
Contributor

Description

Reland of #36465 with fixes to analysis

@jonahwilliams jonahwilliams added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 22, 2019
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 22, 2019
@jonahwilliams jonahwilliams requested a review from zanderso July 22, 2019 17:37
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #36699 into master will decrease coverage by 1.09%.
The diff coverage is 72.09%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #36699     +/-   ##
=========================================
- Coverage   56.01%   54.92%   -1.1%     
=========================================
  Files         188      188             
  Lines       17432    17414     -18     
=========================================
- Hits         9765     9565    -200     
- Misses       7667     7849    +182
Flag Coverage Δ
#flutter_tool 54.92% <72.09%> (-1.1%) ⬇️
Impacted Files Coverage Δ
...ackages/flutter_tools/lib/src/commands/unpack.dart 6.93% <ø> (+0.06%) ⬆️
packages/flutter_tools/lib/src/desktop.dart 86.95% <ø> (+8.38%) ⬆️
...kages/flutter_tools/lib/src/commands/assemble.dart 64.86% <ø> (-0.96%) ⬇️
.../flutter_tools/lib/src/commands/build_fuchsia.dart 81.81% <ø> (+68.18%) ⬆️
packages/flutter_tools/lib/src/device.dart 65.06% <ø> (-2.56%) ⬇️
...ackages/flutter_tools/lib/src/commands/create.dart 72.78% <0%> (ø) ⬆️
.../flutter_tools/lib/src/runner/flutter_command.dart 82.35% <0%> (-0.24%) ⬇️
...lutter_tools/lib/src/windows/windows_workflow.dart 100% <100%> (ø) ⬆️
packages/flutter_tools/lib/src/plugins.dart 86.23% <100%> (ø) ⬆️
...es/flutter_tools/lib/src/macos/macos_workflow.dart 100% <100%> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d3d45...c1b720b. Read the comment docs.

@jonahwilliams
Copy link
Contributor Author

cc @stuartmorgan

@jonahwilliams jonahwilliams merged commit 3fedb8c into flutter:master Jul 22, 2019
@jonahwilliams jonahwilliams deleted the use_web_config branch July 22, 2019 22:34
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants