Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland Integrate dwds into flutter tool for web support #37650

Merged
merged 1 commit into from Aug 5, 2019
Merged

Reland Integrate dwds into flutter tool for web support #37650

merged 1 commit into from Aug 5, 2019

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Aug 5, 2019 •
edited

Reverts #37649

The infra failure is unrelated. Landing TBR @yjbanov

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos team Infra upgrades, team productivity, code health, technical debt. See also team: labels. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. labels Aug 5, 2019
@jonahwilliams jonahwilliams changed the title Revert "Revert "Integrate dwds into flutter tool for web support"" Reland Integrate dwds into flutter tool for web support Aug 5, 2019
@jonahwilliams jonahwilliams merged commit a785db7 into master Aug 5, 2019
@jonahwilliams jonahwilliams deleted the revert-37649-revert-34252-merge_webdev branch August 5, 2019 23:52
yjbanov
yjbanov reviewed Aug 6, 2019
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert
Copy link
Contributor

This regressed our "technical_debt__cost dependencies_count" benchmark. If that was intended, please re-baseline the benchmark.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov left review comments

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. d: examples Sample code and demos team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonahwilliams @tvolkert @yjbanov @googlebot @fluttergithubbot