Place existing dill into hot reload temp directory to boost initialization time #40366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
Codecov Report
@@ Coverage Diff @@
## master #40366 +/- ##
==========================================
+ Coverage 58.4% 59.06% +0.65%
==========================================
Files 192 192
Lines 18627 18622 -5
==========================================
+ Hits 10880 10999 +119
+ Misses 7747 7623 -124
Continue to review full report at Codecov.
|
aam
approved these changes
Sep 12, 2019
zanderso
reviewed
Sep 12, 2019
| @@ -548,6 +548,16 @@ abstract class ResidentRunner { | |||
| if (!artifactDirectory.existsSync()) { | |||
| artifactDirectory.createSync(recursive: true); | |||
| } | |||
| // TODO(jonahwilliams): this is a temporary work around to regain some of | |||
| // the initialize from dill performance. Longer term, we should have a | |||
| // better way to determine where the appropriate dill file is, as this | |||
There was a problem hiding this comment.
Is there an issue filed for this?
There was a problem hiding this comment.
Filled #40388
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to recover some of the performance loss from moving hot reload artifacts to a temporary directory. If there is a dill file in build/app.dill then copy that into temp.