Remove Source.behavior, fix bug in depfile invalidation #43945
Conversation
fluttergithubbot
added
the
tool
|
I have a fix pending that allows me to remove the skip in dart-archive/file.dart#132 |
| @@ -526,17 +526,17 @@ class _BuildInstance { | |||
| await node.target.build(environment); | |||
| printTrace('${node.target.name}: Complete'); | |||
|
|
|||
| // If we were missing the depfile, resolve files after executing the | |||
| node.inputs.clear(); | |||
There was a problem hiding this comment.
Maybe:
node.inputs
..clear()
..addAll(...);
node.outputs
..clear()
..addAll(...);| @@ -58,6 +58,9 @@ class Depfile { | |||
| /// | |||
| /// If either [inputs] or [outputs] is empty, does not write to the file. | |||
| void writeToFile(File depfile) { | |||
| if (depfile.existsSync()) { | |||
There was a problem hiding this comment.
The writeAsStringSync() below will truncate the file, so I guess this delete is needed for the case where inputs or outputs is empty. Maybe add a comment to that effect, or move the delete under the if for the inputs/outputs.
There was a problem hiding this comment.
Moved under the if and added more to the method's doc comment
| /// A helper function to copy an asset bundle into an [environment]'s output | ||
| /// directory. | ||
| /// | ||
| /// [pathSuffix] may be optionally provided to add additional paths to the |
There was a problem hiding this comment.
It looks like this parameter no longer eixsts.
| @@ -65,7 +67,7 @@ flutter: | |||
|
|
|||
| // See https://github.com/flutter/flutter/issues/35293 | |||
| expect(fs.file(fs.path.join(environment.buildDir.path, 'flutter_assets', 'assets/foo/bar.png')).existsSync(), false); | |||
| })); | |||
| }), skip: Platform.isWindows); // See https://github.com/google/file.dart/issues/131 | |||
There was a problem hiding this comment.
Does this imply that stale files will be left in the build directory on Windows? Could this result in an incorrect build?
There was a problem hiding this comment.
I could not reproduce this on a real filesystem, which leads me to believe it is only an issue with the memory filesystem.
* remove Source.behavior, fix bug in depfile invalidation * more cleanup of assets * Add skip * address comments * Update build_system.dart
Description
Remove Source.behavior and all custom asset behavior. This is now replaced with a single helper method that returns a depfile.
Fixes a bug in depfile invalidation. IF a depfile already existed, we would not recompute the outputs after running it. Thus, changes in the outputs expressed in the depfile would not be picked up until a subsequent run. This delayed the removal of stale files.
See the test case that demonstrates the issue
The test skip is due to a bug in package:file https://github.com/google/file.dart/issues/131