Skip to content

remove unnecessary string interpolations #49622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

remove unnecessary string interpolations #49622

merged 1 commit into from
Jan 31, 2020

Conversation

a14n
Copy link
Contributor

@a14n a14n commented Jan 28, 2020

Description

Remove unnecessary string interpolations. Same changes as #49602 expect for one case where the interpolation was guarding null.

Related Issues

Tests

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 28, 2020
@a14n a14n mentioned this pull request Jan 28, 2020
Merged
a14n
a14n commented Jan 28, 2020
View reviewed changes
packages/flutter/lib/src/foundation/_isolates_io.dart Outdated
@@ -80,7 +80,7 @@ class _IsolateConfiguration<Q, R> {
Future<void> _spawn<Q, R>(_IsolateConfiguration<Q, FutureOr<R>> configuration) async {
R result;
await Timeline.timeSync(
'${configuration.debugLabel}',
'${configuration.debugLabel}', // ignore: unnecessary_string_interpolations, guarding null value
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only ignore case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also just change this to coallesce to something like <isolate label optimized out>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rebase my PR once #49638 is merged.

@a14n a14n force-pushed the unnecessary_string_interpolations branch 2 times, most recently from 02a44a5 to eb2d936 Compare January 29, 2020 08:02
@a14n
Copy link
Contributor Author

a14n commented Jan 29, 2020

rebased. PTAL

@jonahwilliams jonahwilliams removed the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 30, 2020
@a14n a14n force-pushed the unnecessary_string_interpolations branch from eb2d936 to b3902b2 Compare January 30, 2020 20:32
dnfield
dnfield approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a14n a14n merged commit b5f328e into flutter:master Jan 31, 2020
@a14n a14n deleted the unnecessary_string_interpolations branch January 31, 2020 17:30
@Ikuyadeu Ikuyadeu mentioned this pull request Feb 4, 2020
Closed
9 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a14n @dnfield @googlebot @jonahwilliams @fluttergithubbot