[flutter_tools] handle missing null check in manifest parser #57400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
zanderso
approved these changes
May 18, 2020
| @@ -565,7 +565,9 @@ class ApkManifestData { | |||
| } | |||
|
|
|||
| final _Element application = manifest.firstElement('application'); | |||
| assert(application != null); | |||
There was a problem hiding this comment.
How about the assert up on line 537? Does it need the same fix?
There was a problem hiding this comment.
I'm not sure since I don't have the original context. It is possible the dump output never contains fewer than 3 lines, so that prevents test regressions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This assert should have been a null check to prevent an NPE when
<application>is missing from the android manifest.Fixes #57281