New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed magical color. #5886
Merged
Merged
Removed magical color. #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
approved these changes
Sep 15, 2016
color: const Color(0xFFD1D9E1), | ||
border: new Border( | ||
bottom: new BorderSide( | ||
color: Theme.of(context).dividerColor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code uses Theme.of() twice, create a final ThemeData variable.
LGTM |
Changed drawer header to use theme's divider color.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@95e91e3...8b8c52e git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884) 2018-07-26 stanislav@gmail.com Fix compilation trace memory management problem 2018-07-26 bkonyi@google.com Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881) 2018-07-26 goderbauer@google.com Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880) 2018-07-26 chinmaygarde@gmail.com Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878) 2018-07-26 liyuqian@google.com Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877) 2018-07-26 chinmaygarde@gmail.com Remove all dependencies on Garnet. (flutter#5869) 2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875) 2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) 2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868) 2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823) 2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865) 2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862) 2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861) 2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents. 2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method. 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859) 2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853) 2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855) 2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854) 2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852) 2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@95e91e3...8b8c52e git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884) 2018-07-26 stanislav@gmail.com Fix compilation trace memory management problem 2018-07-26 bkonyi@google.com Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881) 2018-07-26 goderbauer@google.com Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880) 2018-07-26 chinmaygarde@gmail.com Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878) 2018-07-26 liyuqian@google.com Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877) 2018-07-26 chinmaygarde@gmail.com Remove all dependencies on Garnet. (flutter#5869) 2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875) 2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) 2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868) 2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823) 2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865) 2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862) 2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861) 2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents. 2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method. 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859) 2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853) 2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855) 2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854) 2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852) 2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 27, 2018
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...27c9de5 git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...27c9de5 git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 27, 2018
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...27c9de5 git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 27, 2018
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...27c9de5 git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...9420da1 git log 6f7bdc9..9420da1 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888) 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...9420da1 git log 6f7bdc9..9420da1 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888) 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Jul 27, 2018
72a38a6 Build Android engine in presubmit using Cirrus and GCE (flutter#5882) f9f40ba Log uncaught exceptions from JNI calls at a higher priority (flutter#5891) 723b278 Update license script README (flutter#5890) 9420da1 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888) 27c9de5 Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 8b8c52e Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 89602cc [scenic] Expose compositor context from rasterizer. (flutter#5739) 9baeb9c Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
liyuqian
added a commit
that referenced
this pull request
Jul 28, 2018
72a38a6 Build Android engine in presubmit using Cirrus and GCE (#5882) f9f40ba Log uncaught exceptions from JNI calls at a higher priority (#5891) 723b278 Update license script README (#5890) 9420da1 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (#5888) 27c9de5 Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (#5887) 8b8c52e Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (#5886) 89602cc [scenic] Expose compositor context from rasterizer. (#5739) 9baeb9c Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (#5885)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed drawer header to use theme's divider color.