Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollable calls setState within a build phase due to extent change #5846

Closed
apwilson opened this issue Sep 13, 2016 · 7 comments
Closed

Scrollable calls setState within a build phase due to extent change #5846

apwilson opened this issue Sep 13, 2016 · 7 comments
Assignees
@Hixie
Labels
f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Milestone
2: Make Early Ado...

Comments

@apwilson
Copy link
Contributor 

11:01:05.832: I/flutter : ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
11:01:05.834: I/flutter : The following assertion was thrown during performLayout():
11:01:05.837: I/flutter : Build scheduled during frame.
11:01:05.839: I/flutter : While the widget tree was being built, laid out, and painted, a new frame was scheduled to rebuild
11:01:05.841: I/flutter : the widget tree. This might be because setState() was called from a layout or paint callback. If a
11:01:05.844: I/flutter : change is needed to the widget tree, it should be applied as the tree is being built. Scheduling a
11:01:05.846: I/flutter : change for the subsequent frame instead results in an interface that lags behind by one frame. If
11:01:05.849: I/flutter : this was done to make your build dependent on a size measured at layout time, consider using a
11:01:05.852: I/flutter : LayoutBuilder, CustomSingleChildLayout, or CustomMultiChildLayout. If, on the other hand, the one
11:01:05.855: I/flutter : frame delay is the desired effect, for example because this is an animation, consider scheduling the
11:01:05.857: I/flutter : frame in a post-frame callback using SchedulerBinding.addPostFrameCallback or using an
11:01:05.860: I/flutter : AnimationController to trigger the animation.
11:01:05.895: I/flutter : When the exception was thrown, this was the stack:
11:01:05.904: I/flutter : #0      BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding&WidgetsBinding._handleBuildScheduled.<anonymous closure> (package:flutter/src/widgets/binding.dart:199:9)
11:01:05.907: I/flutter : #2      BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding&WidgetsBinding._handleBuildScheduled (package:flutter/src/widgets/binding.dart:197:12)
11:01:05.909: I/flutter : #3      BuildOwner.scheduleBuildFor (package:flutter/src/widgets/framework.dart:1456:23)
11:01:05.912: I/flutter : #4      BuildableElement.markNeedsBuild (package:flutter/src/widgets/framework.dart:2223:11)
11:01:05.914: I/flutter : #5      State.setState (package:flutter/src/widgets/framework.dart:840:14)
11:01:05.916: I/flutter : #6      ScrollableState._setScrollOffset (package:flutter/src/widgets/scrollable.dart:386:5)
11:01:05.919: I/flutter : #7      ScrollableState.scrollTo (package:flutter/src/widgets/scrollable.dart:431:7)
11:01:05.922: I/flutter : #8      ScrollableState.didUpdateScrollBehavior (package:flutter/src/widgets/scrollable.dart:468:5)
11:01:05.924: I/flutter : #9      ScrollableState.handleExtentsChanged (package:flutter/src/widgets/scrollable.dart:481:5)
11:01:05.927: I/flutter : #10     ScrollableViewport._buildViewport.<anonymous closure> (package:flutter/src/widgets/scrollable.dart:916:15)
11:01:05.929: I/flutter : #11     RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:289:46)
11:01:05.932: I/flutter : #12     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.934: I/flutter : #13     RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:91:13)
11:01:05.937: I/flutter : #14     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.939: I/flutter : #15     RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:91:13)
11:01:05.942: I/flutter : #16     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.945: I/flutter : #17     RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:91:13)
11:01:05.947: I/flutter : #18     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.950: I/flutter : #19     RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:249:13)
11:01:05.953: I/flutter : #20     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.955: I/flutter : #21     RenderPositionedBox.performLayout (package:flutter/src/rendering/shifted_box.dart:336:13)
11:01:05.958: I/flutter : #22     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.960: I/flutter : #23     RenderStack.performLayout (package:flutter/src/rendering/stack.dart:394:15)
11:01:05.963: I/flutter : #24     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.965: I/flutter : #25     RenderStack.performLayout (package:flutter/src/rendering/stack.dart:354:15)
11:01:05.968: I/flutter : #26     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.971: I/flutter : #27     RenderConstrainedOverflowBox.performLayout (package:flutter/src/rendering/shifted_box.dart:512:13)
11:01:05.973: I/flutter : #28     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.976: I/flutter : #29     RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:91:13)
11:01:05.978: I/flutter : #30     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.981: I/flutter : #31     RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:249:13)
11:01:05.983: I/flutter : #32     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.986: I/flutter : #33     RenderFlex.performLayout (package:flutter/src/rendering/flex.dart:421:15)
11:01:05.989: I/flutter : #34     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.991: I/flutter : #35     _RenderLayoutBuilder.performLayout (package:flutter/src/widgets/layout_builder.dart:203:13)
11:01:05.994: I/flutter : #36     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.997: I/flutter : #37     RenderStack.performLayout (package:flutter/src/rendering/stack.dart:354:15)
11:01:05.999: I/flutter : #38     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:06.002: I/flutter : #39     _RenderLayoutBuilder.performLayout (package:flutter/src/widgets/layout_builder.dart:203:13)
11:01:06.004: I/flutter : #40     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:06.007: I/flutter : #41     RenderFlex.performLayout (package:flutter/src/rendering/flex.dart:471:17)
11:01:06.009: I/flutter : #42     RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1424:21)
11:01:06.012: I/flutter : #43     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:874:18)
11:01:06.015: I/flutter : #44     BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding.beginFrame (package:flutter/src/rendering/binding.dart:202:19)
11:01:06.018: I/flutter : #45     BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding&WidgetsBinding.beginFrame (package:flutter/src/widgets/binding.dart:297:23)
11:01:06.021: I/flutter : #46     BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:147:5)
11:01:06.024: I/flutter : #47     BindingBase&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:608:15)
11:01:06.027: I/flutter : #48     BindingBase&SchedulerBinding.handleBeginFrame (package:flutter/src/scheduler/binding.dart:543:9)
11:01:06.030: I/flutter : #49     _beginFrame (file:///b/build/slave/Linux_Engine/build/src/flutter/lib/ui/hooks.dart:48)
@dragostis dragostis added ⚠ bug framework flutter/packages/flutter repository. See also f: labels. labels Sep 13, 2016
@HansMuller
Copy link
Contributor

It looks like #5752 was supposed to avoid this issue but the ScrollableState.handleExtentsChanged() clearly leads to a setState() in _setScrollOffset().

cc @Hixie

@Hixie Hixie modified the milestone: Flutter 0.8 Sep 16, 2016
@Hixie
Copy link
Contributor

Hixie commented Sep 20, 2016

Do you recall how to trigger this?

@Hixie
Copy link
Contributor

Hixie commented Sep 20, 2016

I think one way to trigger this would be to have a scroll behavior that always tried to be scrolled to half the contentExtent. When the size of the scrollable changes during layout, this would change the scroll offset synchronously during layout.

@Hixie
Copy link
Contributor

Hixie commented Sep 20, 2016

fix in #5966

@Hixie Hixie added waiting for PR to land (fixed) A fix is in flight f: scrolling Viewports, list views, slivers, etc. and removed waiting for PR to land (fixed) A fix is in flight labels Sep 20, 2016
@Hixie Hixie self-assigned this Sep 23, 2016
@Hixie Hixie mentioned this issue Sep 27, 2016
Closed
@mpcomplete
Copy link
Contributor

Fixed by #6310

@eseidelGoogle
Copy link
Contributor

Based on the last comment sounds like we can close this?

@abarth abarth moved this from Widget stuff to Metabugs in Scrolling Refactor Feb 10, 2017
@abarth abarth moved this from Metabugs to DONE in Scrolling Refactor Feb 10, 2017
@Hixie Hixie removed this from CLOSED in Scrolling Refactor Jun 22, 2017
amirh pushed a commit to amirh/flutter that referenced this issue Jul 25, 2018
Roll engine to 7d17da7
0d6b318 
```
7d17da7 Package Skia licenses into a separate file from other third party libraries (flutter#5861)
d2d8bf3 Pass touch events to embedded Android views with dispatchTouchEvents.
2169086 Synthesize Android MotionEvents with the long form obtain method.
0b44327 Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
f50e218 Rename clip mode to clip behavior (flutter#5853)
42bd86d Make the virtual display's presentation window non focusable. (flutter#5845)
a726e1d Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
3fa83d2 Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
75ad439 Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
5cd8b45 Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
e12b528 Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
5bc1e68 Remove check_roll from Travis (flutter#5846)
```
liyuqian added a commit to liyuqian/flutter that referenced this issue Jul 25, 2018
@liyuqian
Roll engine to 336c23f
4be6b76 
336c23f Remove //flutter/glue and use FML directly. (flutter#5862)
7d17da7 Package Skia licenses into a separate file from other third party libraries (flutter#5861)
d2d8bf3 Pass touch events to embedded Android views with dispatchTouchEvents.
2169086 Synthesize Android MotionEvents with the long form obtain method.
0b44327 Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
f50e218 Rename clip mode to clip behavior (flutter#5853)
42bd86d Make the virtual display's presentation window non focusable. (flutter#5845)
a726e1d Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
3fa83d2 Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
75ad439 Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
5cd8b45 Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
e12b528 Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
5bc1e68 Remove check_roll from Travis (flutter#5846)
@liyuqian liyuqian mentioned this issue Jul 25, 2018
Closed
amirh added a commit that referenced this issue Jul 25, 2018
@amirh
Roll engine to 7d17da7 (#19785)
8adecb6 
```
7d17da7 Package Skia licenses into a separate file from other third party libraries (#5861)
d2d8bf3 Pass touch events to embedded Android views with dispatchTouchEvents.
2169086 Synthesize Android MotionEvents with the long form obtain method.
0b44327 Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (#5859)
f50e218 Rename clip mode to clip behavior (#5853)
42bd86d Make the virtual display's presentation window non focusable. (#5845)
a726e1d Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (#5857)
3fa83d2 Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (#5856)
75ad439 Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (#5855)
5cd8b45 Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (#5854)
e12b528 Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (#5852)
5bc1e68 Remove check_roll from Travis (#5846)
```
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 26, 2018
Roll engine 95e91e3..66f87f4 (22 commits)
27a532a 
git@github.com:flutter/engine.git
/+log/95e91e31fad8..66f87f4

git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@66f87f4f4cd7

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this issue Jul 26, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 26, 2018
Roll engine 95e91e3..66f87f4 (22 commits)
ae8037a 
git@github.com:flutter/engine.git
/+log/95e91e31fad8..66f87f4

git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@66f87f4f4cd7

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this issue Jul 26, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 26, 2018
Roll engine 95e91e3..66f87f4 (22 commits)
26ca63d 
flutter/flutter@95e91e3...66f87f4f4cd704c49e465d0c2a87cdc794de359e/+log/95e91e31fad8..66f87f4f4cd7

git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@66f87f4f4cd7

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Jul 26, 2018
Closed
Closed
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 26, 2018
Roll engine 95e91e3..2c6fa0d (24 commits)
8c58b6a 
flutter/engine@95e91e3...2c6fa0d7b026d3b4c8196820946016ec821bd171/+log/95e91e31fad8..2c6fa0d7b026

git log 95e91e3..2c6fa0d --date=short --no-merges --format='%ad %ae %s'
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@2c6fa0d7b026

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Jul 26, 2018
Closed
Closed
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 26, 2018
Roll engine 95e91e3..503ba7c (25 commits)
4d788c5 
flutter/engine@95e91e3...503ba7c

2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this issue Jul 26, 2018
Closed
@rmistry rmistry mentioned this issue Jul 26, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 27, 2018
Roll engine 95e91e3..8b8c52e (36 commits)
2622acf 
flutter/engine@95e91e3...8b8c52e

git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884)
2018-07-26 stanislav@gmail.com Fix compilation trace memory management problem
2018-07-26 bkonyi@google.com Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881)
2018-07-26 goderbauer@google.com Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880)
2018-07-26 chinmaygarde@gmail.com Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
2018-07-26 liyuqian@google.com Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877)
2018-07-26 chinmaygarde@gmail.com Remove all dependencies on Garnet. (flutter#5869)
2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this issue Jul 27, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 27, 2018
Roll engine 95e91e3..8b8c52e (36 commits)
69c68bf 
flutter/engine@95e91e3...8b8c52e

git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884)
2018-07-26 stanislav@gmail.com Fix compilation trace memory management problem
2018-07-26 bkonyi@google.com Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881)
2018-07-26 goderbauer@google.com Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880)
2018-07-26 chinmaygarde@gmail.com Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
2018-07-26 liyuqian@google.com Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877)
2018-07-26 chinmaygarde@gmail.com Remove all dependencies on Garnet. (flutter#5869)
2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@github-actions
Copy link

github-actions bot commented Sep 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Hixie Hixie

Labels
f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
2: Make Early Adopters happy
Development

No branches or pull requests
6 participants
@apwilson @Hixie @mpcomplete @HansMuller @dragostis @eseidelGoogle