Scrollable should restore its viewport dimensions when it reappears #5862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| containerExtent: _containerExtent, | ||
| scrollOffset: scrollOffset | ||
| ); | ||
| didUpdateScrollBehavior(updatedOffset); |
There was a problem hiding this comment.
why not inline the updatedOffset?
|
LGTM |
HansMuller
force-pushed
the
scroll_config_viewport_dimensions
branch
from
df8d4ac
to
36dbf70
Compare
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Jul 25, 2018
336c23f Remove //flutter/glue and use FML directly. (flutter#5862) 7d17da7 Package Skia licenses into a separate file from other third party libraries (flutter#5861) d2d8bf3 Pass touch events to embedded Android views with dispatchTouchEvents. 2169086 Synthesize Android MotionEvents with the long form obtain method. 0b44327 Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859) f50e218 Rename clip mode to clip behavior (flutter#5853) 42bd86d Make the virtual display's presentation window non focusable. (flutter#5845) a726e1d Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857) 3fa83d2 Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856) 75ad439 Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855) 5cd8b45 Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854) e12b528 Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852) 5bc1e68 Remove check_roll from Travis (flutter#5846)
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 26, 2018
git@github.com:flutter/engine.git /+log/95e91e31fad8..66f87f4 git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) 2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871) 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868) 2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823) 2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865) 2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862) 2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861) 2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents. 2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method. 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859) 2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853) 2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855) 2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854) 2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852) 2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846) Created with: gclient setdep -r engine@66f87f4f4cd7 The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 26, 2018
git@github.com:flutter/engine.git /+log/95e91e31fad8..66f87f4 git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) 2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871) 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868) 2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823) 2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865) 2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862) 2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861) 2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents. 2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method. 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859) 2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853) 2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855) 2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854) 2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852) 2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846) Created with: gclient setdep -r engine@66f87f4f4cd7 The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Jul 26, 2018
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 26, 2018
flutter/flutter@95e91e3...66f87f4f4cd704c49e465d0c2a87cdc794de359e/+log/95e91e31fad8..66f87f4f4cd7 git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) 2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871) 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868) 2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823) 2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865) 2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862) 2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861) 2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents. 2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method. 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859) 2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853) 2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855) 2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854) 2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852) 2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846) Created with: gclient setdep -r engine@66f87f4f4cd7 The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 26, 2018
flutter/engine@95e91e3...2c6fa0d7b026d3b4c8196820946016ec821bd171/+log/95e91e31fad8..2c6fa0d7b026 git log 95e91e3..2c6fa0d --date=short --no-merges --format='%ad %ae %s' 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875) 2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866) 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) 2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871) 2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868) 2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823) 2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865) 2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862) 2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861) 2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents. 2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method. 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859) 2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853) 2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856) 2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855) 2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854) 2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852) 2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846) Created with: gclient setdep -r engine@2c6fa0d7b026 The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Jul 26, 2018
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 26, 2018
flutter/engine@95e91e3...503ba7c 2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875) 2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) 2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868) 2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823) 2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865) 2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862) 2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861) 2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents. 2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method. 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859) 2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853) 2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855) 2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854) 2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852) 2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Jul 26, 2018
dbd2f57 Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878) 76e9f79 Only check trailing spaces for dart and don't check for CRLF (flutter#5877) 9f8285a Remove all dependencies on Garnet. (flutter#5869) 503ba7c Dart SDK roll for 2018/07/26 (flutter#5876) 2c6fa0d Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875) f480e32 Support hot reload in corejit mode (flutter#5866) 66f87f4 Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2193ff4 Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) aef291b Unify trailing spaces / new lines (flutter#5871) 6193743 Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 7624c8a Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) cfcb701 Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 1d1c8c7 Rename clip to clipBehavior in compositing.dart (flutter#5868) d559afb Support customizing standard accessibility actions on Android. (flutter#5823) 228cecc Make //flutter/synchronization Garnet free. (flutter#5865) 336c23f Remove //flutter/glue and use FML directly. (flutter#5862)
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Jul 26, 2018
896441a Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880) de206ea Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879) dbd2f57 Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878) 76e9f79 Only check trailing spaces for dart and don't check for CRLF (flutter#5877) 9f8285a Remove all dependencies on Garnet. (flutter#5869) 503ba7c Dart SDK roll for 2018/07/26 (flutter#5876) 2c6fa0d Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875) f480e32 Support hot reload in corejit mode (flutter#5866) 66f87f4 Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2193ff4 Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) aef291b Unify trailing spaces / new lines (flutter#5871) 6193743 Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 7624c8a Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) cfcb701 Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 1d1c8c7 Rename clip to clipBehavior in compositing.dart (flutter#5868) d559afb Support customizing standard accessibility actions on Android. (flutter#5823) 228cecc Make //flutter/synchronization Garnet free. (flutter#5865) 336c23f Remove //flutter/glue and use FML directly. (flutter#5862)
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@95e91e3...8b8c52e git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884) 2018-07-26 stanislav@gmail.com Fix compilation trace memory management problem 2018-07-26 bkonyi@google.com Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881) 2018-07-26 goderbauer@google.com Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880) 2018-07-26 chinmaygarde@gmail.com Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878) 2018-07-26 liyuqian@google.com Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877) 2018-07-26 chinmaygarde@gmail.com Remove all dependencies on Garnet. (flutter#5869) 2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875) 2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) 2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868) 2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823) 2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865) 2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862) 2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861) 2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents. 2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method. 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859) 2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853) 2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855) 2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854) 2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852) 2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@95e91e3...8b8c52e git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884) 2018-07-26 stanislav@gmail.com Fix compilation trace memory management problem 2018-07-26 bkonyi@google.com Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881) 2018-07-26 goderbauer@google.com Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880) 2018-07-26 chinmaygarde@gmail.com Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878) 2018-07-26 liyuqian@google.com Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877) 2018-07-26 chinmaygarde@gmail.com Remove all dependencies on Garnet. (flutter#5869) 2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875) 2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873) 2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871) 2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867) 2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868) 2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823) 2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865) 2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862) 2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861) 2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents. 2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method. 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859) 2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853) 2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856) 2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855) 2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854) 2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852) 2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a scrollable is reactivated its dependenciesChanged() method recreates the scroll behavior.
The new scroll behavior needs to be configured with the viewport's current (contentExtent, containerExtent) dimensions.
Fixes #5856