New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hot reload for applications that don't use the framework #5868

Merged

johnmccutchan merged 1 commit into flutter:master from johnmccutchan:handle_non_framework_applications

Sep 15, 2016

Contributor

johnmccutchan commented Sep 14, 2016 •

edited

If any extension RPCs return a method not found error, ignore the error as it indicates the application isn't using the framework.
Always follow a 'reassemble' with a 'ext.ui.window.scheduleFrame' so that non-framework applications benefit from hot reload.

Fixes #5863

Contributor Author

johnmccutchan commented Sep 14, 2016

johnmccutchan mentioned this pull request

Hot reload doesn't seem to work with applications that don't use the framework #5863

Closed

Hixie reviewed

View reviewed changes

packages/flutter_tools/lib/src/hot.dart

    
            @@ -491,12 +491,18 @@ class HotRunner extends ResidentRunner {
          
                      logger.startProgress('Reassembling application...');

                  try {

                    await currentView.uiIsolate.flutterReassemble();

                  } catch (_) {

                  } catch (e) {

                    reassembleStatus.stop(showElapsedTime: true);

Contributor

Hixie Sep 14, 2016

Presumably you meant to check the type of e?

Contributor

Hixie Sep 14, 2016

Oh never mind, I see what you did.

Contributor Author

johnmccutchan Sep 15, 2016

I actually don't need the exception here so I'm restoring it to "_".

Hixie reviewed

View reviewed changes

packages/flutter_tools/lib/src/hot.dart

    
                  try {

                    /* ensure that a frame is scheduled */

                    await currentView.uiIsolate.uiWindowScheduleFrame();

                  } catch (_) {

Contributor

Hixie Sep 14, 2016

use "e" instead of "_"

Contributor Author

johnmccutchan Sep 15, 2016

I actually don't need the exception here so I'm keeping it as "_".

Hixie reviewed

View reviewed changes

packages/flutter_tools/lib/src/vmservice.dart

    
                  } catch (e) {

                    // If an application is not using the framework

                    if (_isMethodNotFoundException(e)) {

                      return null;

Contributor

Hixie Sep 14, 2016

no braces

Contributor Author

johnmccutchan Sep 15, 2016

Done.

Hixie reviewed

View reviewed changes

packages/flutter_tools/lib/src/vmservice.dart

    
                  } catch (e) {

                    // If an application is not using the framework

                    if (_isMethodNotFoundException(e)) {

                      return null;

Contributor

Hixie Sep 14, 2016

no braces

Contributor Author

johnmccutchan Sep 15, 2016

Done.

Hixie reviewed

View reviewed changes

packages/flutter_tools/lib/src/vmservice.dart

    
                    });

                  } catch (e) {

                    // If an application is not using the framework

                    if (_isMethodNotFoundException(e)) {

Contributor

Hixie Sep 14, 2016

ditto

Contributor Author

johnmccutchan Sep 15, 2016

Done.

Hixie reviewed

View reviewed changes

packages/flutter_tools/lib/src/vmservice.dart

    
                        const Duration(seconds: 2), onTimeout: () => null);

                  } catch (e) {

                    // If an application is not using the framework

                    if (_isMethodNotFoundException(e)) {

Contributor

Hixie Sep 14, 2016

ditto

Contributor Author

johnmccutchan Sep 15, 2016

Done.

Hixie reviewed

View reviewed changes

packages/flutter_tools/lib/src/vmservice.dart

    
                      return null;

                    }

                    rethrow;

                  }

                }

Contributor

Hixie Sep 14, 2016

maybe this try/catch logic should be in the invokeRpcRaw method itself?

Contributor Author

johnmccutchan Sep 15, 2016

I've refactored this code so there is an invokeFlutterExtensionRpcRaw which consumes the method not found error.

Contributor

Hixie commented Sep 15, 2016

(I went to rereview this with the new factored out invokeFlutterExtensionRpcRaw but the patch in the PR doesn't yet seem to have it.)


          Support hot reload for applications that don't use the framework

ca42ac7

Contributor Author

johnmccutchan commented Sep 15, 2016

Oops. Just refreshed the PR.

Contributor

Hixie commented Sep 15, 2016

johnmccutchan merged commit 24ab837 into flutter:master

rmistry pushed a commit to rmistry/flutter that referenced this pull request


          Roll engine 95e91e3..66f87f4 (22 commits)

27a532a

git@github.com:flutter/engine.git
/+log/95e91e31fad8..66f87f4

git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@66f87f4f4cd7

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

rmistry mentioned this pull request

Roll engine 95e91e31fad8..66f87f4f4cd7 (22 commits) #19813

Closed

rmistry pushed a commit to rmistry/flutter that referenced this pull request


          Roll engine 95e91e3..66f87f4 (22 commits)

ae8037a

git@github.com:flutter/engine.git
/+log/95e91e31fad8..66f87f4

git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@66f87f4f4cd7

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

This was referenced Jul 26, 2018

Roll engine 95e91e31fad8..66f87f4f4cd7 (22 commits) #19814

Closed

Roll engine 95e91e31fad8..66f87f4f4cd7 (22 commits) #19815

Closed

rmistry pushed a commit to rmistry/flutter that referenced this pull request


          Roll engine 95e91e3..66f87f4 (22 commits)

26ca63d

flutter/flutter@95e91e3...66f87f4f4cd704c49e465d0c2a87cdc794de359e/+log/95e91e31fad8..66f87f4f4cd7

git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@66f87f4f4cd7

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

rmistry mentioned this pull request

Roll engine 95e91e31fad8..2c6fa0d7b026 (24 commits) #19821

Closed

rmistry pushed a commit to rmistry/flutter that referenced this pull request


          Roll engine 95e91e3..2c6fa0d (24 commits)

8c58b6a

flutter/engine@95e91e3...2c6fa0d7b026d3b4c8196820946016ec821bd171/+log/95e91e31fad8..2c6fa0d7b026

git log 95e91e3..2c6fa0d --date=short --no-merges --format='%ad %ae %s'
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@2c6fa0d7b026

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

This was referenced Jul 26, 2018

Roll engine 95e91e31fad8..2c6fa0d7b026 (24 commits) #19822

Closed

Roll engine 95e91e31fad8..503ba7c4103d (25 commits) #19827

Closed

rmistry pushed a commit to rmistry/flutter that referenced this pull request


          Roll engine 95e91e3..503ba7c (25 commits)

4d788c5

flutter/engine@95e91e3...503ba7c

2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.

rmistry mentioned this pull request

Roll engine 95e91e31fad8..503ba7c4103d (25 commits) #19828

Closed

rmistry mentioned this pull request

Roll engine 95e91e31fad8..503ba7c4103d (25 commits) #19829

Closed

liyuqian added a commit to liyuqian/flutter that referenced this pull request


          Roll engine to dbd2f57

41be7e7

dbd2f57 Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
76e9f79 Only check trailing spaces for dart and don't check for CRLF (flutter#5877)
9f8285a Remove all dependencies on Garnet. (flutter#5869)
503ba7c Dart SDK roll for 2018/07/26 (flutter#5876)
2c6fa0d Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
f480e32 Support hot reload in corejit mode (flutter#5866)
66f87f4 Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2193ff4 Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
aef291b Unify trailing spaces / new lines (flutter#5871)
6193743 Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
7624c8a Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
cfcb701 Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
1d1c8c7 Rename clip to clipBehavior in compositing.dart (flutter#5868)
d559afb Support customizing standard accessibility actions on Android. (flutter#5823)
228cecc Make //flutter/synchronization Garnet free. (flutter#5865)
336c23f Remove //flutter/glue and use FML directly. (flutter#5862)

liyuqian mentioned this pull request

Roll engine to dbd2f57e0e5e697087b89a95d7182307dbd6e273 #19834

Closed

liyuqian added a commit to liyuqian/flutter that referenced this pull request


          Roll engine to 896441a

896441a Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880)
de206ea Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
dbd2f57 Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
76e9f79 Only check trailing spaces for dart and don't check for CRLF (flutter#5877)
9f8285a Remove all dependencies on Garnet. (flutter#5869)
503ba7c Dart SDK roll for 2018/07/26 (flutter#5876)
2c6fa0d Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
f480e32 Support hot reload in corejit mode (flutter#5866)
66f87f4 Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2193ff4 Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
aef291b Unify trailing spaces / new lines (flutter#5871)
6193743 Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
7624c8a Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
cfcb701 Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
1d1c8c7 Rename clip to clipBehavior in compositing.dart (flutter#5868)
d559afb Support customizing standard accessibility actions on Android. (flutter#5823)
228cecc Make //flutter/synchronization Garnet free. (flutter#5865)
336c23f Remove //flutter/glue and use FML directly. (flutter#5862)

liyuqian mentioned this pull request

Roll engine to 896441ad8de4cbf3f9070712976b77cf6b3138d8 #19838

Closed

jonahwilliams mentioned this pull request

roll engine to 6f7bdc9fabef810b14577deef5cf330029fd290e #19848

Merged

rmistry pushed a commit to rmistry/flutter that referenced this pull request


          Roll engine 95e91e3..8b8c52e (36 commits)

2622acf

flutter/engine@95e91e3...8b8c52e

git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884)
2018-07-26 stanislav@gmail.com Fix compilation trace memory management problem
2018-07-26 bkonyi@google.com Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881)
2018-07-26 goderbauer@google.com Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880)
2018-07-26 chinmaygarde@gmail.com Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
2018-07-26 liyuqian@google.com Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877)
2018-07-26 chinmaygarde@gmail.com Remove all dependencies on Garnet. (flutter#5869)
2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.

rmistry pushed a commit to rmistry/flutter that referenced this pull request


          Roll engine 95e91e3..8b8c52e (36 commits)

69c68bf

flutter/engine@95e91e3...8b8c52e

git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884)
2018-07-26 stanislav@gmail.com Fix compilation trace memory management problem
2018-07-26 bkonyi@google.com Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881)
2018-07-26 goderbauer@google.com Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880)
2018-07-26 chinmaygarde@gmail.com Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
2018-07-26 liyuqian@google.com Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877)
2018-07-26 chinmaygarde@gmail.com Remove all dependencies on Garnet. (flutter#5869)
2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 3762641&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.

rmistry mentioned this pull request

Roll engine 95e91e31fad8..8b8c52ed7f76 (36 commits) #19870

Closed

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.