Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SizedBox ignores the scaling factor on a child Transform #5874

Closed
mpcomplete opened this issue Sep 14, 2016 · 9 comments
Closed

SizedBox ignores the scaling factor on a child Transform #5874

mpcomplete opened this issue Sep 14, 2016 · 9 comments

Comments

@mpcomplete
Copy link
Contributor

Try this sample:

  runApp(new Align(
    alignment: FractionalOffset.topCenter,
    child: new SizedBox(
      height: 50.0,
      child: new Transform(
        transform: new Matrix4.identity()
                   ..scale(1.0, 0.5),
        child: new Column(
          children: <Widget>[
            new Flexible(flex: null, child: new Container(decoration: new BoxDecoration(backgroundColor: Colors.green[500]), height: 2.0*20.0)),
            new Flexible(flex: null, child: new Container(decoration: new BoxDecoration(backgroundColor: Colors.white), height: 2.0*30.0)),
          ]
        )
      )
    )
  ));

The Transform has a 100px high child, which it scales to 50px high. This should fit fine inside the SizedBox, but the SizedBox paints an angry red overflow indicator on the bottom half of its child. If the SizedBox instead has an untransformed 50px child, everything is fine. It seems the SizedBox applies its constraints to the child before the transform is applied.

@Hixie
Copy link
Contributor

Hixie commented Sep 14, 2016

The red is coming from the Column. It only has 50.0 pixels to play with (max height constraint coming from the parent SizedBox) but you've put 100 pixels of stuff inside it (two children, one 40 pixels high and one 60 pixels high).

Transform doesn't change the constraints, it just passes them straight from the parent to the child. Consider a non-affine perspective transform combined with an arbitrary rotation and a shear... what would you do to the box constraints if you were to manipulate them in some way?

@Hixie
Copy link
Contributor

Hixie commented Sep 14, 2016

The way to debug this, by the way, is debugDumpRenderTree

@mpcomplete
Copy link
Contributor Author

Transform doesn't change the constraints

Ah, that's probably the cause of #5850 and maybe #5671 .

I understand the technical reasons for it, but this still seems wrong to me. Is there a workaround? I want to put WxH pixels of stuff inside a Transform, and shrink it down to fit in its container. Since that container is going to be smaller than WxH, I'm going to get the red overflow paint.

@Hixie
Copy link
Contributor

Hixie commented Sep 14, 2016

I think you want either this widget: https://github.com/flutter/game/blob/master/lib/render_coordinate_system.dart
Or this widget: #5830

Both are easy to write if you want to write them.

Container will not show red overflow paint. Only Row and Column do that.

@mpcomplete
Copy link
Contributor Author

Presumably #5830 will be built using Transform, so it will need to solve this problem too.

Is there some way I can wrap the Column to tell it that it has more space than it thinks? Wrapping it in a Container or SizedBox with a manual height does nothing (presumably because their ancestor has a smaller height). I need to position 2 widgets. Maybe a Stack instead of Column?

@Hixie
Copy link
Contributor

Hixie commented Sep 15, 2016

I would imagine #5380 would be built as its own RenderObject, a peer to Transform rather than built on it, since it needs to read the child size and so forth.

I don't really understand what you're trying to do. Can you elaborate on your larger goal?

@mpcomplete
Copy link
Contributor Author

I'm trying to get the Pesto logo to smoothly animate between image and image+text. My approach involves drawing the image+text as separate components, which requires scaling them together. See #5890 for a working implementation - where I ended up using Stack instead of Column.

@mpcomplete
Copy link
Contributor Author

Sounds like it's WAI that Transform does not affect child sizes.

rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 26, 2018
git@github.com:flutter/engine.git
/+log/95e91e31fad8..66f87f4

git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@66f87f4f4cd7

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 26, 2018
git@github.com:flutter/engine.git
/+log/95e91e31fad8..66f87f4

git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@66f87f4f4cd7

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 26, 2018
flutter/flutter@95e91e3...66f87f4f4cd704c49e465d0c2a87cdc794de359e/+log/95e91e31fad8..66f87f4f4cd7

git log 95e91e3..66f87f4 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@66f87f4f4cd7

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 26, 2018
flutter/engine@95e91e3...2c6fa0d7b026d3b4c8196820946016ec821bd171/+log/95e91e31fad8..2c6fa0d7b026

git log 95e91e3..2c6fa0d --date=short --no-merges --format='%ad %ae %s'
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display's presentation window non focusable. (flutter#5845)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

Created with:
  gclient setdep -r engine@2c6fa0d7b026

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 26, 2018
flutter/engine@95e91e3...503ba7c

2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
liyuqian added a commit to liyuqian/flutter that referenced this issue Jul 26, 2018
dbd2f57 Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
76e9f79 Only check trailing spaces for dart and don't check for CRLF (flutter#5877)
9f8285a Remove all dependencies on Garnet. (flutter#5869)
503ba7c Dart SDK roll for 2018/07/26 (flutter#5876)
2c6fa0d Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
f480e32 Support hot reload in corejit mode (flutter#5866)
66f87f4 Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2193ff4 Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
aef291b Unify trailing spaces / new lines (flutter#5871)
6193743 Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
7624c8a Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
cfcb701 Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
1d1c8c7 Rename clip to clipBehavior in compositing.dart (flutter#5868)
d559afb Support customizing standard accessibility actions on Android. (flutter#5823)
228cecc Make //flutter/synchronization Garnet free. (flutter#5865)
336c23f Remove //flutter/glue and use FML directly. (flutter#5862)
liyuqian added a commit to liyuqian/flutter that referenced this issue Jul 26, 2018
896441a Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880)
de206ea Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
dbd2f57 Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
76e9f79 Only check trailing spaces for dart and don't check for CRLF (flutter#5877)
9f8285a Remove all dependencies on Garnet. (flutter#5869)
503ba7c Dart SDK roll for 2018/07/26 (flutter#5876)
2c6fa0d Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
f480e32 Support hot reload in corejit mode (flutter#5866)
66f87f4 Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2193ff4 Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
aef291b Unify trailing spaces / new lines (flutter#5871)
6193743 Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
7624c8a Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
cfcb701 Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
1d1c8c7 Rename clip to clipBehavior in compositing.dart (flutter#5868)
d559afb Support customizing standard accessibility actions on Android. (flutter#5823)
228cecc Make //flutter/synchronization Garnet free. (flutter#5865)
336c23f Remove //flutter/glue and use FML directly. (flutter#5862)
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 27, 2018
flutter/engine@95e91e3...8b8c52e

git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884)
2018-07-26 stanislav@gmail.com Fix compilation trace memory management problem
2018-07-26 bkonyi@google.com Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881)
2018-07-26 goderbauer@google.com Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880)
2018-07-26 chinmaygarde@gmail.com Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
2018-07-26 liyuqian@google.com Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877)
2018-07-26 chinmaygarde@gmail.com Remove all dependencies on Garnet. (flutter#5869)
2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this issue Jul 27, 2018
flutter/engine@95e91e3...8b8c52e

git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 mikejurka@gmail.com [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884)
2018-07-26 stanislav@gmail.com Fix compilation trace memory management problem
2018-07-26 bkonyi@google.com Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881)
2018-07-26 goderbauer@google.com Roll buildroot to 4fd7a2738de8fc8f9b498437cde96c1bf7562a04 (flutter#5880)
2018-07-26 chinmaygarde@gmail.com Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
2018-07-26 liyuqian@google.com Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877)
2018-07-26 chinmaygarde@gmail.com Remove all dependencies on Garnet. (flutter#5869)
2018-07-26 bkonyi@google.com Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 stanislav@gmail.com Support hot reload in corejit mode (flutter#5866)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 liyuqian@google.com Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 liyuqian@google.com Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 jonahwilliams@google.com Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 chinmaygarde@gmail.com Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 chinmaygarde@gmail.com Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 jason-simmons@users.noreply.github.com Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 amirha@google.com Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 amirha@google.com Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 liyuqian@google.com Rename clip mode to clip behavior (flutter#5853)
2018-07-25 amirh@users.noreply.github.com Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415&flutter#43;skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 liyuqian@google.com Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants