[devicelab] disable image list duration tests #64486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
c: contributor-productivity
|
Landing TBR to green the tree |
|
/cc @aam who wrote this test. |
|
LGTM |
|
Certificate was deemed to be critical part of this test as the tests focus on https-related infrastructure. |
|
Then ideally the test would handle an expired certificate by printing a reasonable error message + instructions on re-generating (at the minimum) |
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These tests have a specified certificate which has expired. They should be rewritten differently to not require renewing this cert, perhaps by using an HttpClient override to simulate network loading?
https://github.com/flutter/flutter/blob/master/examples/image_list/lib/main.dart#L19