[flutter_tools] optimize fetch requests and remove main.dart.js bypass #66069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
ditman
reviewed
Sep 17, 2020
ditman
approved these changes
Sep 17, 2020
Comment on lines
+556
to
560
| // If the URL is not the RESOURCE list then return to signal that the | ||
| // browser should take over. | ||
| if (!RESOURCES[key]) { | ||
| return event.respondWith(fetch(event.request)); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Ah, I was understanding "remove main.dart.js bypass" wrong. This lets the service worker cache the main.dart.js again, by not overriding its name with a hash.
(I was about to ask: if we want the serviceworker to bypass main.dart.js, shouldn't we also remove it from the RESOURCES map? :P)
There was a problem hiding this comment.
Yes, exactly - now that I realize I was COMPLETE WRONG about the default behavior of sw, everything makes more sense!
But we also bypass the worker for http requests that won't go to the cache, since I guess there is overhead for forwarding the requests
goderbauer
pushed a commit
to goderbauer/flutter
that referenced
this pull request
Sep 18, 2020
flutter#66069) The main.dart.js bypass is not needed now that we have skipWaiting. Additionally optimize the fetch handler so that resources not in the cache skip the service worker altogether. Fixes flutter#66068
This was referenced Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main.dart.js bypass is not needed now that we have skipWaiting. Additionally optimize the fetch handler so that resources not in the cache skip the service worker altogether.
Fixes #66068