-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Try the Wayland GDK backend, the engine now supports it #66519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try the Wayland GDK backend, the engine now supports it #66519
Conversation
/CC @wmww |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will test tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working good
One strange thing I noticed (probably not introduced here) is that on both X11 and Wayland there are GTK-styled client-side-decorations, but on Wayland they look different and only have a close button (no maximize/minimize). I will look into this a little bit now. |
Hmm, that behavior difference between X11 and Wayland looks to be the default behavior of |
@stuartmorgan is this unblocked? |
It's not blocked, just waiting for Robert to be back to respond to feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Try the Wayland GDK backend, the engine now supports it (flutter/engine#20629), merged in 277a87f
Related Issues
Fixes #57932
Tests
No tests added.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.