Skip to content

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Sep 24, 2020

Description

Try the Wayland GDK backend, the engine now supports it (flutter/engine#20629), merged in 277a87f

Related Issues

Fixes #57932

Tests

No tests added.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 24, 2020
@robert-ancell
Copy link
Contributor Author

/CC @wmww

Copy link

@wmww wmww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@wmww wmww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will test tomorrow

Copy link

@wmww wmww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working good

@wmww
Copy link

wmww commented Sep 24, 2020

One strange thing I noticed (probably not introduced here) is that on both X11 and Wayland there are GTK-styled client-side-decorations, but on Wayland they look different and only have a close button (no maximize/minimize). I will look into this a little bit now.

@wmww
Copy link

wmww commented Sep 24, 2020

Hmm, that behavior difference between X11 and Wayland looks to be the default behavior of GtkHeaderBar and applies to all GTK apps. It could also be depended on my theme or other configuration. Not a problem with Flutter in any case.

@jonahwilliams
Copy link
Contributor

@stuartmorgan is this unblocked?

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan is this unblocked?

It's not blocked, just waiting for Robert to be back to respond to feedback.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[linux] Support Wayland in GTK embedding
5 participants