[flutter_tools] check asset files while the tool waits for the frontend_server compile #67826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
commented
Oct 10, 2020
| if (fullRestart) { | ||
| generator.reset(); | ||
| } | ||
| // On a full restart, or on an initial compile for the attach based workflow, |
There was a problem hiding this comment.
This logic is unchanged, but the asset stat was placed in between the pendingCompilerOutput resolution.
jonahwilliams
changed the title
zanderso
approved these changes
Oct 12, 2020
| // The tool writes the assets into the AssetBundle working dir so that they | ||
| // are in the same location in DevFS and the iOS simulator. | ||
| final String assetBuildDirPrefix = _asUriPath(getAssetBuildDirectory()); | ||
| final String assetDirectory = getAssetBuildDirectory(); | ||
| bundle.entries.forEach((String archivePath, DevFSContent content) { |
There was a problem hiding this comment.
Where does the stat happen? Is it done as part of the isModified and size getters?
| // this will produce a full dill. Subsequent invocations will produce incremental | ||
| // dill files that depend on the invalidated files. | ||
| _logger.printTrace('Compiling dart to kernel with ${invalidatedFiles.length} updated files'); | ||
| final Future<CompilerOutput> pendingCompilerOutput = generator.recompile( |
There was a problem hiding this comment.
Maybe add a comment here explaining why the Future is awaited later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On every hot reload, the flutter tool must file stat each asset in the bundle. With a large number of assets or a slow file system, this can take 20 - 30 ms. Do this operation while the flutter tool is waiting for a response from the frontend_server.
No tests updated since this is only a timing update. Any difference in behavior will be shown on benchmarks