Revert "[flutter_tools] listen to the nice ios-deploy tool" #68118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #68078
We shouldn't uninstall iOS apps out from the user. If it's the last app on the phone using the development cert, users have to go back in and approve on the next install.
That message is from Detach debugger when VM connection fails on iOS #68046 not the ios-deploy. That message should probably be "try quitting the app and try again" not uninstall. I'll open a PR for that.
There's something Bad happening in the devicelab that isn't caused by this, it's just manifesting this way. If we uninstall the app and retry we will be hiding flakes because it really took 2 tries but we would count it as working on the first go.