Skip to content

[flutter_tools] fix --use-existing-app for flutter drive #69237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

[flutter_tools] fix --use-existing-app for flutter drive #69237

merged 1 commit into from
Oct 28, 2020

Conversation

jonahwilliams
Copy link
Contributor

Description

This is the likely cause of the benchmark regressions

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 28, 2020
@google-cla google-cla bot added the cla: yes label Oct 28, 2020
@zanderso
Copy link
Member

Could you link this to the issues for the benchmark regressions?

@jonahwilliams
Copy link
Contributor Author

Some of them are:

#69206
#69204
#69205

However I have no idea if this will actually fix them as I do not have the devices/time to verify the regressions. But if any of these depended on using an existing app, this fix should change them again

jmagman
jmagman approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit d306c37 into flutter:master Oct 28, 2020
@jonahwilliams jonahwilliams deleted the fix_routing_test_for_real branch October 28, 2020 20:55
@liyuqian liyuqian mentioned this pull request Oct 28, 2020
Closed
@zanderso zanderso mentioned this pull request Oct 28, 2020
Merged
@kf6gpe kf6gpe mentioned this pull request Oct 29, 2020
Closed
This was referenced Nov 2, 2020
Closed
Closed
@jmagman jmagman mentioned this pull request Oct 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahwilliams @zanderso @jmagman