Update plugins dependencies for the Gallery test

[blasten]

Re-attempts #69238

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[jonahwilliams]

Still LGTM

[blasten]

same issue :/ cc @dnfield - should we disable this test?

[jonahwilliams]

@blasten is this the same branch? Or did you re-branch from a later commit?

Only the former will change your flutter version

[blasten]

New branch but with same commits from the previous one. Would that be the issue?

[jonahwilliams]

I don't think so

[jonahwilliams]

Could flutter_svg loosen the constraint a bit? @dnfield

[blasten]

what about we don't block this PR on the flutter_svg issue?

[dnfield]

We should be able to retag flutter SVG with a dev version that this won't fail on. I don't think I'll get to that before tomorrow but if anyone else does I can help land

[blasten]

@mehmetf are we allowing null-safety plugins internally? I might need to do that shortly, see "Google testing".

[blasten]

Will import the plugin into g3 in a bit.

[gspencergoog]

@blasten I think this has/will break the build. When I sync, I get multiple analysis errors, and it also looks like several tests were failing when this was merged.

Here are the analysis errors I get on master:

  error • Target of URI doesn't exist: 'package:connectivity_for_web/connectivity_for_web.dart' •
         dev/integration_tests/flutter_gallery/lib/generated_plugin_registrant.dart:8:8 • uri_does_not_exist
  error • Target of URI doesn't exist: 'package:url_launcher_web/url_launcher_web.dart' •
         dev/integration_tests/flutter_gallery/lib/generated_plugin_registrant.dart:9:8 • uri_does_not_exist
  error • Undefined name 'ConnectivityPlugin' • dev/integration_tests/flutter_gallery/lib/generated_plugin_registrant.dart:16:3 •
         undefined_identifier
  error • The argument type 'dynamic' can't be assigned to the parameter type 'Type' •
         dev/integration_tests/flutter_gallery/lib/generated_plugin_registrant.dart:16:57 • argument_type_not_assignable
  error • Undefined name 'ConnectivityPlugin' • dev/integration_tests/flutter_gallery/lib/generated_plugin_registrant.dart:16:57 •
         undefined_identifier
  error • Undefined name 'UrlLauncherPlugin' • dev/integration_tests/flutter_gallery/lib/generated_plugin_registrant.dart:17:3 •
         undefined_identifier
  error • The argument type 'dynamic' can't be assigned to the parameter type 'Type' •
         dev/integration_tests/flutter_gallery/lib/generated_plugin_registrant.dart:17:56 • argument_type_not_assignable
  error • Undefined name 'UrlLauncherPlugin' • dev/integration_tests/flutter_gallery/lib/generated_plugin_registrant.dart:17:56 •
         undefined_identifier

[gspencergoog]

Nevermind: this was just cruft left in my repo, after cleaning I get no analysis errors.

But why was this committed with failing tests?

[blasten]

@gspencergoog the errors are unrelated, and due to dnfield/flutter_svg#435. The g3 test is being fixed internally.

[Hixie]

why are we pinning path_provider?
(just asking because i'm adding comments to update_packages.dart)

[blasten]

I'm not sure why path_provider was pinned. maybe @jonahwilliams ?