[flutter_tools] run web unit tests in sound null safety #70799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
c: contributor-productivity
added 6 commits
November 18, 2020 16:51
| @@ -44,12 +57,12 @@ class BuildRunnerWebCompilationProxy extends WebCompilationProxy { | |||
| globals.fs.path.join(outputDirectory.path, '${relativeTestSegments.join('_')}.test.dart')); | |||
| generatedFile | |||
| ..createSync(recursive: true) | |||
| ..writeAsStringSync(_generateEntrypoint(relativeTestSegments.join('/'), testFilePath)); | |||
| ..writeAsStringSync(_generateEntrypoint(relativeTestSegments.join('/'), testFilePath, languageVersion)); | |||
| generatedFiles.add(generatedFile); | |||
| } | |||
| // Generate a fake main file that imports all tests to be executed. This will force | |||
There was a problem hiding this comment.
TIL this is what we do
|
The test can be fixed by modifying some lines in Future<ByteData?>? send(String channel, ByteData? message) {
final Completer<ByteData?> completer = Completer<ByteData?>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does not yet support autodetect, but allows flutter test --platform chrome to run in sound mode. does some minimal plumbing to also support canvaskit.
Fixes #70715