Skip to content

Conversation

jonahwilliams
Copy link
Contributor

Description

The web-server device will only appear if run with -d web-server or with --show-web-server-device

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 1, 2020
@google-cla google-cla bot added the cla: yes label Dec 1, 2020
@jonahwilliams jonahwilliams requested a review from nturgut December 1, 2020 18:23
Copy link
Contributor

@nturgut nturgut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks, since long running tests are passing, I assume the integration tests on the engine side will also be fine.

@yeysus
Copy link

yeysus commented Jan 2, 2021

Hi. I think somebody should update the Documentation / Getting Started. https://flutter.dev/docs/get-started/codelab, 2020.01.03, says a Web server should be listed in flutter devices. Now accoding to above it is shown only with flutter devices --show-web-server-device.

@matthew-carroll
Copy link
Contributor

+1 for appropriate documentation updates. The getting start guide is currently wrong. It took me a while to find this thread to see that the option I was looking for was hidden.

@jonahwilliams what was the rationale behind hiding this option?

@dzianis-dashkevich-old
Copy link

just curious, why?

@omatt
Copy link

omatt commented Mar 3, 2021

@matthew-carroll @DenisDashkevich
Tim explained the rationale behind this feature here #75088 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants