[flutter_tools] remove mockito from mdns client test #76747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jmagman
approved these changes
Feb 25, 2021
| expect(uri.toString(), 'http://127.0.0.1:123/'); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| class MockMDnsClient extends Mock implements MDnsClient {} | ||
| class FakeMDnsClient extends Fake implements MDnsClient { |
There was a problem hiding this comment.
When these Fakes get elaborate I'm always worried we're testing the fake class and not the actual interactions in prod. If only we had a mocking framework... But it's the same concern for complicated mocks.
There was a problem hiding this comment.
Its important to remember that unit tests really just exist to catch the most trivial of errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #71511