Skip to content

[flutter_tools] Fix avdmanager path detection #78166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2021
Merged

[flutter_tools] Fix avdmanager path detection #78166

merged 1 commit into from
Mar 15, 2021

Conversation

GurjinderPartola
Copy link
Contributor

The old Android SDK tools ($ANDROID_SDK_ROOT/tools/bin) have been deprecated in favor of the new cmdline-tools (see https://developer.android.com/studio/releases/sdk-tools).
The sdkmanager binary can be detected at both locations, this PR does the same for the avdmanager binary.

Fixes #64035.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 14, 2021
@google-cla google-cla bot added the cla: yes label Mar 14, 2021
@GurjinderPartola GurjinderPartola changed the title Fix avdmanager path detection [flutter_tools] Fix avdmanager path detection Mar 14, 2021
@jonahwilliams jonahwilliams self-requested a review March 15, 2021 14:30
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fluttergithubbot fluttergithubbot merged commit 2e17a8e into flutter:master Mar 15, 2021
@GurjinderPartola GurjinderPartola deleted the android-avdmanager-path branch March 15, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android command line tools sdk folder structure is inconsistent with the expected search path for the sdkmanager
3 participants