[flutter_tools] dont require a device for screenshot type skia/rasterizer #80153
+75
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jonahwilliams
commented
Apr 9, 2021
| @@ -87,8 +88,7 @@ class ScreenshotCommand extends FlutterCommand { | |||
|
|
|||
| @override | |||
| Future<FlutterCommandResult> verifyThenRunCommand(String commandPath) async { | |||
| device = await findTargetDevice(); | |||
There was a problem hiding this comment.
this was the problem line
Hixie
reviewed
Apr 9, 2021
| switch (screenshotType) { | ||
| case _kDeviceType: | ||
| device = await findTargetDevice(); | ||
| if (device == null) { | ||
| throwToolExit('Must have a connected device for screenshot type $screenshotType'); | ||
| } |
There was a problem hiding this comment.
while you're at it you could throw if observatoryUri is non-null (see #80151)
Hixie
reviewed
Apr 9, 2021
|
|
||
| await expectLater(() => createTestCommandRunner(ScreenshotCommand()) | ||
| .run(<String>['screenshot', '--type=skia', '--observatory-uri=http://localhost:8181']), | ||
| throwsException, |
There was a problem hiding this comment.
should we be checking what exception is thrown exactly? it seems like if this regressed, it would still actually throw an exception...
|
Thanks for fixing this. Didn't mean to nerd-snipe you. :-) |
|
No worries :) I'm just happy to know what this command is supposed to be used for |
|
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter screenshot does not require a device for rasterizer/skia. Move device lookup so that it only happens when the device type is selected. update unit tests to run more of the command logic.
Fixes #80149
Fixes #80151