Add space to the clipping region of physical model layers with shadows #9654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Apr 27, 2017
| // picture's bounds, so we draw a hardcoded amount of extra space to | ||
| // account for the maximum potential area of the shadow. | ||
| canvas.drawRect(offsetBounds.inflate(20.0), | ||
| new Paint()..color=const Color(0)); |
There was a problem hiding this comment.
This seems pretty hacky (painting invisible black should be a no-op, inflating by 20 pixels seems arbitrary). Is there a long-term fix planned?
At a minimum we should add a TODO to fix this.
There was a problem hiding this comment.
At some point Skia should provide a way to calculate the area drawn by the shadow and adjust the picture's size accordingly. Until that's available, we need to do some other operation that causes the picture to extend its bounds.
There was a problem hiding this comment.
Cool, in that case the TODO can just be "Remove this once skia does it for us". :-)
jason-simmons
force-pushed
the
skia_shadow_0426
branch
from
3cd6bab to
d1c6e09
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.