Skip to content

Add example with "maxAllowedSelections": 1 #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add example with "maxAllowedSelections": 1 #451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5056e6
-
polina-c Oct 26, 2025
c9c8739
Update multiple_choice.dart
polina-c Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions packages/flutter_genui/lib/src/catalog/core_widgets/multiple_choice.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,5 +140,34 @@ final multipleChoice = CatalogItem(
}
]
''',
() => '''
[
{
"id": "root",
"component": {
"MultipleChoice": {
"selections": {
"path": "/mySelections"
},
"maxAllowedSelections": 1,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The maxAllowedSelections property is a great addition, but its logic doesn't seem to be implemented in the MultipleChoice widget builder.

Specifically:

  • The onChanged handler (lines 90-105) adds/removes items from the selections list without respecting maxAllowedSelections. When an item is selected, it should check if the limit is reached. If maxAllowedSelections is 1, selecting a new item should deselect any previously selected item.
  • When maxAllowedSelections is 1, it would be more intuitive to render RadioListTile widgets instead of CheckboxListTile to visually indicate that only one option can be selected.
  • Additionally, there are no tests for the maxAllowedSelections behavior. A test case should be added to verify the correct behavior when maxAllowedSelections is set, especially for the single-selection case.

Since this PR adds an example for a feature that is not yet implemented, it could be misleading. I'd recommend implementing this logic and adding tests as part of this PR, or removing this example for now.

Copy link
Collaborator Author

@polina-c polina-c Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true: #448

"options": [
{
"label": {
"literalString": "Radio Button 1"
},
"value": "1"
},
{
"label": {
"literalString": "Radio Button 2"
},
"value": "2"
}
]
}
}
}
]
''',
],
);
Loading