Implement flex weight for components. #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gspencergoog
force-pushed
the
implement_flex
branch
from
5b875fe to
26c0891
Compare
gspencergoog
force-pushed
the
implement_flex
branch
from
83fbe17 to
e132822
Compare
gspencergoog
force-pushed
the
implement_flex
branch
from
e132822 to
6eae226
Compare
jacobsimionato
approved these changes
Oct 30, 2025
| final weight = component?.weight; | ||
| final childWidget = buildChild(id, dataContext); | ||
| if (weight != null) { | ||
| return Expanded(flex: weight, child: childWidget); |
Collaborator
There was a problem hiding this comment.
Neat! Previously, I had assumed that introducing these interactions between child/parent widgets would add too much complexity to the rendering engine to make sense, but I guess it's not actually that bad. Now I see how we could implement the "hero image" pattern that Paul is after for full bleed images at the top of cards.
gspencergoog
force-pushed
the
implement_flex
branch
from
c29177b to
c2c1dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements the
weightattribute for components as anExpandedwith a flex factor for components that haveweightset.