Skip to content

Conversation

@jacobsimionato
Copy link
Collaborator

@jacobsimionato jacobsimionato commented Dec 5, 2025

This needs to match the name used in the agent examples for them to work together.

I will update the name on the agent side separately, because it's currently at v0.1.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the A2UI extension URL, but the change is incomplete. The old URL is still used in the sendEvent method, which will cause inconsistent behavior. My review comment suggests defining the URL as a constant and using it in both places to fix the issue and improve maintainability. I also recommend enhancing the tests to verify the extensions payload, which would have caught this inconsistency.

@jacobsimionato jacobsimionato changed the title Update A2UI extension name to https://a2ui.org/a2a-extension/v0.8 Update A2UI extension name to https://a2ui.org/ext/a2a-ui/v0.8 Dec 5, 2025
@gspencergoog
Copy link
Collaborator

Isn't A2A-UI a different thing from A2UI? I thought there was another extension with that name? Or is that how we merged them?

@jacobsimionato jacobsimionato changed the title Update A2UI extension name to https://a2ui.org/ext/a2a-ui/v0.8 Update A2UI extension name to https://a2ui.org/a2a-extension/v0.8 Dec 5, 2025
@jacobsimionato
Copy link
Collaborator Author

jacobsimionato commented Dec 5, 2025

Updated to https://a2ui.org/a2a-extension/a2ui/v0.8 :-D

@gspencergoog gspencergoog changed the title Update A2UI extension name to https://a2ui.org/a2a-extension/v0.8 Update A2UI extension name to https://a2ui.org/a2a-extension/a2ui/v0.8 Dec 5, 2025
@gspencergoog gspencergoog merged commit be54230 into flutter:main Dec 5, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants