Skip to content

Conversation

AbdeMohlbi
Copy link
Contributor

@AbdeMohlbi AbdeMohlbi commented Sep 30, 2025

Update minimum flutter version to 3.35 to force a minimum AGP version to something that requires java 17.
part of #176027

All dart code changes were formatter changes.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@AbdeMohlbi AbdeMohlbi changed the title WIP [quick_actions] updates build files to use JVM 17 Sep 30, 2025
@AbdeMohlbi AbdeMohlbi marked this pull request as ready for review September 30, 2025 07:39
@reidbaker reidbaker self-requested a review October 2, 2025 14:50
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 2, 2025
@auto-submit auto-submit bot merged commit 28088d3 into flutter:main Oct 2, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Oct 2, 2025
flutter/packages@321a584...5fd5f74

2025-10-02 mohellebiabdessalem@gmail.com [url_launcher] updates build
files to use JVM 17 (flutter/packages#10130)
2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build
files to use JVM 17 (flutter/packages#10132)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
c9608e2 to 7811e89 (22 revisions) (flutter/packages#10160)
2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove
references to dart:js_util (flutter/packages#10148)
2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy
emulator tests (flutter/packages#10141)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
96fe3b3 to c9608e2 (26 revisions) (flutter/packages#10145)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Oct 7, 2025
…r#176409)

flutter/packages@321a584...5fd5f74

2025-10-02 mohellebiabdessalem@gmail.com [url_launcher] updates build
files to use JVM 17 (flutter/packages#10130)
2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build
files to use JVM 17 (flutter/packages#10132)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
c9608e2 to 7811e89 (22 revisions) (flutter/packages#10160)
2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove
references to dart:js_util (flutter/packages#10148)
2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy
emulator tests (flutter/packages#10141)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
96fe3b3 to c9608e2 (26 revisions) (flutter/packages#10145)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah pushed a commit to okorohelijah/flutter that referenced this pull request Oct 7, 2025
…r#176409)

flutter/packages@321a584...5fd5f74

2025-10-02 mohellebiabdessalem@gmail.com [url_launcher] updates build
files to use JVM 17 (flutter/packages#10130)
2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build
files to use JVM 17 (flutter/packages#10132)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
c9608e2 to 7811e89 (22 revisions) (flutter/packages#10160)
2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove
references to dart:js_util (flutter/packages#10148)
2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy
emulator tests (flutter/packages#10141)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
96fe3b3 to c9608e2 (26 revisions) (flutter/packages#10145)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: quick_actions platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants