[google_sign_in] Remove references to dart:js_util #10148
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies packages/google_sign_in/google_sign_in/example/lib/src/web_wrapper.dart to update a conditional export. The condition has been changed from dart.library.js_util to dart.library.js_interop, which aligns with the migration to support dart2wasm. The formatting of the export statement has also been updated by splitting it across two lines. The change is self-contained and correct, and I have no further feedback.
|
This is a trivial migration that shouldn't require a CHANGELOG entry, so if a reviewer could add the "override: no changelog needed" label, that'd be lovely. |
stuartmorgan-g
changed the title
|
test-exempt: code refactor with no semantic change |
stuartmorgan-g
added
the
override: no changelog needed
gaaclarke
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/10148, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
gaaclarke
added
the
autosubmit
flutter/packages@321a584...5fd5f74 2025-10-02 mohellebiabdessalem@gmail.com [url_launcher] updates build files to use JVM 17 (flutter/packages#10130) 2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build files to use JVM 17 (flutter/packages#10132) 2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from c9608e2 to 7811e89 (22 revisions) (flutter/packages#10160) 2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove references to dart:js_util (flutter/packages#10148) 2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy emulator tests (flutter/packages#10141) 2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 96fe3b3 to c9608e2 (26 revisions) (flutter/packages#10145) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#176409) flutter/packages@321a584...5fd5f74 2025-10-02 mohellebiabdessalem@gmail.com [url_launcher] updates build files to use JVM 17 (flutter/packages#10130) 2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build files to use JVM 17 (flutter/packages#10132) 2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from c9608e2 to 7811e89 (22 revisions) (flutter/packages#10160) 2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove references to dart:js_util (flutter/packages#10148) 2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy emulator tests (flutter/packages#10141) 2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 96fe3b3 to c9608e2 (26 revisions) (flutter/packages#10145) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#176409) flutter/packages@321a584...5fd5f74 2025-10-02 mohellebiabdessalem@gmail.com [url_launcher] updates build files to use JVM 17 (flutter/packages#10130) 2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build files to use JVM 17 (flutter/packages#10132) 2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from c9608e2 to 7811e89 (22 revisions) (flutter/packages#10160) 2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove references to dart:js_util (flutter/packages#10148) 2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy emulator tests (flutter/packages#10141) 2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 96fe3b3 to c9608e2 (26 revisions) (flutter/packages#10145) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Flutter has already migrated from dart:js_util to dart:js_interop (which is unsupported by dart2wasm). This migrates a remaining reference to js_util which will be broken when dart2wasm drops the library entirely.