Skip to content

Conversation

engine-flutter-autoroll
Copy link
Contributor

Manual roll requested by tarrinneal@google.com

flutter/flutter@96fe3b3...c9608e2

2025-09-30 matt.kosarek@canonical.com Implement framework interface for the dialog window archetype (flutter/flutter#176202)
2025-09-30 jhy03261997@gmail.com Update flutter test to use SemanticsFlags (flutter/flutter#175987)
2025-09-30 1063596+reidbaker@users.noreply.github.com Set minimum supported java version to 17 (flutter/flutter#176226)
2025-09-30 mdebbar@google.com Reduce timeout for Linux web_tool_tests back to 60 (flutter/flutter#176286)
2025-09-30 engine-flutter-autoroll@skia.org Roll Packages from 34eec78 to 287739d (9 revisions) (flutter/flutter#176284)
2025-09-30 mdebbar@google.com [web] Bump Firefox to 143.0 (flutter/flutter#176110)
2025-09-30 32538273+ValentinVignal@users.noreply.github.com Migrate to WidgetStateBorderSide (flutter/flutter#176164)
2025-09-30 78146827+RootHex200@users.noreply.github.com Enhance input decorator padding logic for character counter in text f… (flutter/flutter#175706)
2025-09-30 jacksongardner@google.com Update the test package for the web engine unit test bits. (flutter/flutter#176241)
2025-09-30 robert.ancell@canonical.com Warn if embedder API calls don't return success (flutter/flutter#176184)
2025-09-30 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from APSBP-sS-3FX69Ihf... to JUeFbA8y0E-_pj-bg... (flutter/flutter#176243)
2025-09-30 jason-simmons@users.noreply.github.com Roll GN to 81b24e01 (flutter/flutter#176119)
2025-09-29 matt.kosarek@canonical.com Rename DisplayMonitor to DisplayManager on Win32 (flutter/flutter#175619)
2025-09-29 mohamed.nayef95@gmail.com [Android] Use headingLevel for heading accessibility property (flutter/flutter#175416)
2025-09-29 80628866+markyang92@users.noreply.github.com BUILD.gn: Support LTO build on Linux (flutter/flutter#176191)
2025-09-29 mohellebiabdessalem@gmail.com fix assertEquals arguments are in wrong order in FlutterJNITest.java (flutter/flutter#175728)
2025-09-29 mohellebiabdessalem@gmail.com Add tests for Project getters (flutter/flutter#175994)
2025-09-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8zjcJic_DtvB2Bo2x... to rcOl0yxJb4znJ903Y... (flutter/flutter#176215)
2025-09-29 mohellebiabdessalem@gmail.com Clean up typos in PlatformViewsControllerTest.java (flutter/flutter#175725)
2025-09-29 1063596+reidbaker@users.noreply.github.com Migrate java 11 usage to java 17 usage for templates (flutter/flutter#176203)
2025-09-29 aam@google.com User Invoke-Expression instead of call operator for nested Powershell scripts invocations (on Windows) (flutter/flutter#175941)
2025-09-29 jmccandless@google.com Update changelog as on 3.35 branch (flutter/flutter#176216)
2025-09-29 mohellebiabdessalem@gmail.com fix typo in Crashes.md (flutter/flutter#175959)
2025-09-29 15619084+vashworth@users.noreply.github.com Add scene plugin lifecycle events (flutter/flutter#175866)
2025-09-29 1063596+reidbaker@users.noreply.github.com Migrate tests and documentation to set java version to 17 (flutter/flutter#176204)
2025-09-29 jessiewong401@gmail.com Update Engine CI to use NDK r28c (flutter/flutter#175870)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 30, 2025
Copy link

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 30, 2025
Copy link
Contributor

auto-submit bot commented Sep 30, 2025

autosubmit label was removed for flutter/packages/10145, because - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@tarrinneal tarrinneal closed this Oct 1, 2025
@stuartmorgan-g stuartmorgan-g reopened this Oct 1, 2025
@fluttergithubbot
Copy link

An existing Git SHA, 55c87b56f7e04817f2baa88eb59f1c526df8cc68, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@stuartmorgan-g
Copy link
Collaborator

@vashworth FYI I had to add a kind of gross temporary workaround to the webview_flutter tests to deal with the fact that we have to fake the registry/registrar system (due to a special public native API on that plugin, we can't abstract it) in tests. On master we have to implement the new addSceneDelegate:(NSObject<FlutterSceneLifeCycleDelegate>*), but this code also has to compile on stable, and FlutterSceneLifeCycleDelegate doesn't exist on stable.

For IAP this was easy: Obj-C doesn't care much about types, so I just made it take an NSObject. Swift, however, does care about types, and unlike in Dart it turns out you can't use a looser type (e.g., Any) for an argument when implementing a protocol. So for webview_flutter I had to temporarily stuff some Obj-C back into the native tests, and make the fake registrar on iOS in Obj-C instead of Swift.

@stuartmorgan-g
Copy link
Collaborator

(The other option I can think of is that at one point we had code in the repo tooling that could do on-the-fly edits to test code based on the branch before compiling the tests, to deal with a similar problem we had in Java with changes to the plugin APIs on Android. I really don't want to go that route if we can avoid it though.)

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2025
@auto-submit auto-submit bot merged commit b3c2c34 into flutter:main Oct 1, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Oct 2, 2025
flutter/packages@321a584...5fd5f74

2025-10-02 mohellebiabdessalem@gmail.com [url_launcher] updates build
files to use JVM 17 (flutter/packages#10130)
2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build
files to use JVM 17 (flutter/packages#10132)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
c9608e2 to 7811e89 (22 revisions) (flutter/packages#10160)
2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove
references to dart:js_util (flutter/packages#10148)
2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy
emulator tests (flutter/packages#10141)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
96fe3b3 to c9608e2 (26 revisions) (flutter/packages#10145)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Oct 7, 2025
…r#176409)

flutter/packages@321a584...5fd5f74

2025-10-02 mohellebiabdessalem@gmail.com [url_launcher] updates build
files to use JVM 17 (flutter/packages#10130)
2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build
files to use JVM 17 (flutter/packages#10132)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
c9608e2 to 7811e89 (22 revisions) (flutter/packages#10160)
2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove
references to dart:js_util (flutter/packages#10148)
2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy
emulator tests (flutter/packages#10141)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
96fe3b3 to c9608e2 (26 revisions) (flutter/packages#10145)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-packages-e83706e7-5608-41f4-b1e4-7b52274fc93d-1759264367 branch October 7, 2025 20:33
okorohelijah pushed a commit to okorohelijah/flutter that referenced this pull request Oct 7, 2025
…r#176409)

flutter/packages@321a584...5fd5f74

2025-10-02 mohellebiabdessalem@gmail.com [url_launcher] updates build
files to use JVM 17 (flutter/packages#10130)
2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build
files to use JVM 17 (flutter/packages#10132)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
c9608e2 to 7811e89 (22 revisions) (flutter/packages#10160)
2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove
references to dart:js_util (flutter/packages#10148)
2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy
emulator tests (flutter/packages#10141)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
96fe3b3 to c9608e2 (26 revisions) (flutter/packages#10145)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants