Skip to content

Conversation

@dasyad00
Copy link
Contributor

Explanation post: flutter/flutter#140014 (comment)

Resolves #140014.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with video preview initialization on Windows for certain webcam drivers. The fix involves explicitly querying for video, photo, and audio stream indices instead of relying on predefined constants. A key change is the addition of a call to SetCurrentDeviceMediaType after determining the best media type for preview. These changes are correctly propagated through the photo, preview, and record handlers, and the corresponding tests have been updated. I've identified one potential issue where the search for an audio stream is unconditional, which could cause problems in video-only capture scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[camera_windows] Failed to initialize video preview with latest webcam driver

1 participant