Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Add dependencies to Android CI configs to attempt to fix OOB build failures caused by Ubuntu bot downgrades.

See flutter/flutter#178060

Add dependencies to Android CI configs to attempt to fix OOB build
failures caused by Ubuntu bot downgrades.

See flutter/flutter#178060
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds ninja as a dependency to the linux_android and linux_android_legacy CI configurations. This change is a direct response to build failures caused by recent Ubuntu bot downgrades, as detailed in the associated issue. The addition of this build tool is a logical fix for the described problem. The changes are correct and address the issue. I've added a couple of suggestions to sort the dependency lists alphabetically for better long-term maintainability.

@stuartmorgan-g
Copy link
Collaborator Author

Still waiting for some tests to come back, but it looks like this may be enough to fix the OOB regression; requesting review optimistically.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels Nov 6, 2025
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

1 similar comment
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@auto-submit auto-submit bot merged commit 5f52327 into flutter:main Nov 6, 2025
79 of 81 checks passed
@stuartmorgan-g stuartmorgan-g deleted the missing-ci-deps branch November 6, 2025 14:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 6, 2025
flutter/packages@3d926aa...f13bad3

2025-11-06 stuartmorgan@google.com Add Linux CODEOWNERS
(flutter/packages#10235)
2025-11-06 stuartmorgan@google.com [ci] Add missing deps
(flutter/packages#10366)
2025-11-05 65709676+huanghui1998hhh@users.noreply.github.com [go_router]
ShellRoute will merge GoRouter's observers (flutter/packages#9436)
2025-11-05 dgyurov@gmail.com [pigeon] Update analyzer version
(flutter/packages#10352)
2025-11-04 stuartmorgan@google.com [tool] Remove use of FETCH_HEAD
(flutter/packages#10357)
2025-11-04 engine-flutter-autoroll@skia.org Roll Flutter from
027f2e4 to e5d5c01 (73 revisions) (flutter/packages#10362)
2025-11-04 8490712+ruicraveiro@users.noreply.github.com
[camera_platform_interface] Adds support for video stabilization to
camera_platform_interface (flutter/packages#10337)
2025-11-04 filiph@users.noreply.github.com [google_maps_flutter] Raise
`MapUsedAfterWidgetDisposedError` when map controller used after map
disposed (flutter/packages#9242)
2025-11-04 tarrinneal@gmail.com [pigeon] Replace containsKey with
contains in Kotlin generator (flutter/packages#10274)
2025-11-04 116356835+AbdeMohlbi@users.noreply.github.com [video_player]
Remove `package` in example `AndroidManifest.xml` file
(flutter/packages#10245)
2025-11-04 me@nils.re [flutter_svg] Fixes typo of
`allowDrawingOutsideViewBox` in doc comments. (flutter/packages#10256)
2025-11-04 stuartmorgan@google.com [in_app_purchase] Remove use of
Pigeon's Dart test generator (flutter/packages#10328)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants