[pigeon] Fixes compilation error with unbounded type parameter for InstanceManager #10483
+39
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
tarrinneal
approved these changes
Nov 20, 2025
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 21, 2025
…ter for InstanceManager (flutter/packages#10483)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@b1e2fb0...e67b6be 2025-11-21 danferreiradev@gmail.com [file_selector] Implement canCreateDirectories on macos and linux (flutter/packages#10443) 2025-11-21 stuartmorgan@google.com [various] Replace deprecated Color.value in SVG packages (flutter/packages#10482) 2025-11-20 10687576+bparrishMines@users.noreply.github.com [pigeon] Fixes compilation error with unbounded type parameter for InstanceManager (flutter/packages#10483) 2025-11-20 stuartmorgan@google.com [webview_flutter] Replace deprecated Color.value (flutter/packages#10480) 2025-11-20 stuartmorgan@google.com [google_maps_flutter] Replace deprecated color APIs in platform interface (flutter/packages#10477) 2025-11-20 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b45fa18 to f5a8537 (12 revisions) (flutter/packages#10478) 2025-11-20 engine-flutter-autoroll@skia.org Roll Flutter from de4be4f to 9f383e0 (21 revisions) (flutter/packages#10481) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Nov 21, 2025
…r#178927) flutter/packages@b1e2fb0...e67b6be 2025-11-21 danferreiradev@gmail.com [file_selector] Implement canCreateDirectories on macos and linux (flutter/packages#10443) 2025-11-21 stuartmorgan@google.com [various] Replace deprecated Color.value in SVG packages (flutter/packages#10482) 2025-11-20 10687576+bparrishMines@users.noreply.github.com [pigeon] Fixes compilation error with unbounded type parameter for InstanceManager (flutter/packages#10483) 2025-11-20 stuartmorgan@google.com [webview_flutter] Replace deprecated Color.value (flutter/packages#10480) 2025-11-20 stuartmorgan@google.com [google_maps_flutter] Replace deprecated color APIs in platform interface (flutter/packages#10477) 2025-11-20 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b45fa18 to f5a8537 (12 revisions) (flutter/packages#10478) 2025-11-20 engine-flutter-autoroll@skia.org Roll Flutter from de4be4f to 9f383e0 (21 revisions) (flutter/packages#10481) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IdentityWeakReferencerequires a nonnull value so the input to type parameter togetInstancehas to be nonnull. Its hard to write a meaningful test since this only causes a compilation error on older Kotlin versions, but I added a unit test to make suregetInstancespecifies nonnull.This fixes flutter/flutter#178756 once plugins update generated code.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3