[tool] Remove code analysis from podspec-check #10484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the full build-and-analyze version of `pod lib lint` with the `--quick` version. This means that this step no longer does native code analysis (which `analyze` covers), so it no longer needs an exclusion list for packages with warnings. As a result of this change, flutter/packages no longer has a dependency on the version of Flutter that was published to CocoaPods to facilitate podspec testing. Fixes flutter/flutter#178806
stuartmorgan-g
commented
Nov 20, 2025
| print(frameworkResult.stdout); | ||
| print(frameworkResult.stderr); | ||
|
|
||
| // Lint plugin as library. |
Collaborator
Author
There was a problem hiding this comment.
The difference only matters when building, so we don't need to run both modes.
| 'lint', | ||
| podspecPath, | ||
| '--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices. | ||
| '--skip-tests', |
Collaborator
Author
There was a problem hiding this comment.
These flags aren't used in --quick mode.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the podspec-check command to use pod lib lint --quick instead of a full pod lib lint. This removes the dual-pass linting for library and framework styles and removes the --exclude flag from the CI configuration. The corresponding tests are updated to reflect the new single-pass linting process. My review includes a suggestion to remove a comment that has become obsolete due to these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the full build-and-analyze version of
pod lib lintwith the--quickversion. This means that this step no longer does native code analysis (whichanalyzecovers), so it no longer needs an exclusion list for packages with warnings.As a result of this change, flutter/packages no longer has a dependency on the version of Flutter that was published to CocoaPods to facilitate podspec testing.
Fixes flutter/flutter#178806