-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Android 16] Bump Packages to Robolectric 4.16 #10492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Robolectric dependency to version 4.16 in the build.gradle files for the example applications within the video_player and video_player_android packages. This change standardizes the testing framework version across these related example projects.
flutter/packages@e67b6be...e019cf9 2025-11-24 jessiewong401@gmail.com [Android 16] Bump Packages to Robolectric 4.16 (flutter/packages#10492) 2025-11-24 engine-flutter-autoroll@skia.org Roll Flutter from c8cfb2b to 3f553f6 (11 revisions) (flutter/packages#10510) 2025-11-24 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 6 directories with 2 updates (flutter/packages#10500) 2025-11-22 engine-flutter-autoroll@skia.org Roll Flutter from d438df3 to c8cfb2b (21 revisions) (flutter/packages#10494) 2025-11-21 stuartmorgan@google.com [webview_flutter] Update Pigeon for Kotlin 1.8 compat (flutter/packages#10486) 2025-11-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the gradle-plugin group across 19 directories with 1 update (flutter/packages#10456) 2025-11-21 danferreiradev@gmail.com [file_selector] Add parameter to control whether the new folders button is visible in the file dialog (flutter/packages#9965) 2025-11-21 engine-flutter-autoroll@skia.org Roll Flutter from 9f383e0 to d438df3 (18 revisions) (flutter/packages#10491) 2025-11-21 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f5a8537 to 19074d1 (2 revisions) (flutter/packages#10489) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Last bump to robolectric. The rest were previously done by dependabot. Partially Addresses flutter/flutter#177674 Partially Addresses flutter/flutter#163071 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Last bump to robolectric. The rest were previously done by dependabot.
Partially Addresses flutter/flutter#177674
Partially Addresses flutter/flutter#163071
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3