Skip to content

fix SecurityException when trying to record video with audio disabled #10498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+9 −6
Closed

fix SecurityException when trying to record video with audio disabled #10498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
795321c
fix SecurityException when trying to record video with audio disabled
ivan-vanyusho Nov 17, 2025
441f6e3
Update version android_camerax pubspec.yaml
ivan-vanyusho Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...id_camerax/android/src/main/java/io/flutter/plugins/camerax/PendingRecordingProxyApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,17 @@ public PendingRecording asPersistentRecording(PendingRecording pigeonInstance) {
@NonNull
@Override
public PendingRecording withAudioEnabled(PendingRecording pigeonInstance, boolean initialMuted) {
if (!initialMuted
&& ContextCompat.checkSelfPermission(
getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
if (initialMuted) {
return pigeonInstance;
}

if (ContextCompat.checkSelfPermission(
getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
== PackageManager.PERMISSION_GRANTED) {
return pigeonInstance.withAudioEnabled(false);
return pigeonInstance.withAudioEnabled(true);
}

return pigeonInstance.withAudioEnabled(true);
return pigeonInstance.withAudioEnabled(false);
}
Comment on lines 40 to 52
Copy link

@gemini-code-assist gemini-code-assist bot Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The updated logic correctly handles the audio enabling based on permissions. However, it can be simplified. Instead of returning the instance directly when initialMuted is true, you can consolidate the logic to always call withAudioEnabled with the appropriate boolean value. This makes the flow of control a bit clearer.

public PendingRecording withAudioEnabled(PendingRecording pigeonInstance, boolean initialMuted) {
  boolean enableAudio = !initialMuted && ContextCompat.checkSelfPermission(
          getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
      == PackageManager.PERMISSION_GRANTED;

  if (enableAudio) {
    return pigeonInstance.withAudioEnabled();
  }
  return pigeonInstance;
}


@NonNull
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera_android_camerax
description: Android implementation of the camera plugin using the CameraX library.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.6.24+1
version: 0.6.25

environment:
sdk: ^3.9.0
Expand Down