Skip to content

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Nov 29, 2025

ProxyApis now

  • Generate a Dart PigeonOverrides class that can override constructors and static methods.
  • Use a test PigeonInstanceManager that doesn't make any message calls.

This removes the manually written proxy and replaces its use in tests with PigeonOverrides.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@bparrishMines bparrishMines changed the title Overrides camera [camera_android_camerax] Removes internal native library Dart proxy Nov 29, 2025
@bparrishMines bparrishMines marked this pull request as ready for review December 2, 2025 18:43
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2025
@auto-submit auto-submit bot merged commit e5f8325 into flutter:main Dec 8, 2025
80 checks passed
@bparrishMines bparrishMines deleted the overrides_camera branch December 8, 2025 17:08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 9, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 9, 2025
flutter/packages@33a9a81...338ecd3

2025-12-09 adsonpleal@gmail.com [shared_preferences_tool] Update
dependencies and fix deprecation (flutter/packages#10560)
2025-12-08 47866232+chunhtai@users.noreply.github.com [ci] Use manual
trigger for go_router_batch workflow for testing purp…
(flutter/packages#10475)
2025-12-08 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump camerax_version from 1.5.1 to 1.5.2 in
/packages/camera/camera_android_camerax/android (flutter/packages#10582)
2025-12-08 engine-flutter-autoroll@skia.org Roll Flutter from
5b87203 to b2de367 (38 revisions) (flutter/packages#10587)
2025-12-08 10687576+bparrishMines@users.noreply.github.com
[camera_android_camerax] Removes internal native library Dart proxy
(flutter/packages#10536)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants