Skip to content

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Dec 4, 2025

Fixes flutter/flutter#176451

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a crash that occurs when native objects call to Dart after a hot restart. The fix involves updating the pigeon dependency and regenerating the CameraXLibrary.g.kt file. The new generated code correctly adds checks to verify the existence of native instances before making callbacks to Dart. The CHANGELOG.md and pubspec.yaml files are also updated appropriately.

The code changes are correct, but the pull request does not fully adhere to the repository's contribution guidelines. Please update the pull request title to [camera_android_camerax] fix crash and fill out the PR description, including the checklist and a link to the issue this PR resolves.

@bparrishMines bparrishMines changed the title fix crash [camera_android_camerax] Updates pigeon generation to prevent crash when objects call to Dart after a hot restart Dec 4, 2025
@bparrishMines bparrishMines marked this pull request as ready for review December 4, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Camera initialization fails when re-running the app without stopping it

1 participant