Skip to content

[go_router_builder] Use only one .where() #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023
Merged

[go_router_builder] Use only one .where() #3698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/go_router_builder/lib/src/route_config.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,12 @@ class RouteConfig {
InterfaceElement classElement, {
required String keyName,
}) {
bool whereStatic(FieldElement element) => element.isStatic;
bool whereKeyName(FieldElement element) => element.name == keyName;
final String? fieldDisplayName = classElement.fields
.where(whereStatic)
.where(whereKeyName)
.where((FieldElement element) {
final DartType type = element.type;
if (type is! ParameterizedType) {
if (!element.isStatic ||
element.name != keyName ||
type is! ParameterizedType) {
return false;
}
final List<DartType> typeArguments = type.typeArguments;
Expand Down