Skip to content

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Oct 18, 2023

Fixes flutter/flutter#136833
Should probably land #5039 first

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added the p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package label Oct 18, 2023
@Piinks
Copy link
Contributor Author

Piinks commented Oct 26, 2023

Will update to show a render overflow error instead of throwing a fatal crash. 👍

@stuartmorgan-g
Copy link
Collaborator

@Piinks Is this still something you are working on?

@Piinks
Copy link
Contributor Author

Piinks commented Dec 12, 2023

Nope! Thanks for the reminder it was still here. Working on a different solution

@Piinks Piinks closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[two_dimensional_scrollables] TableView pinned rows and columns should warn if pinned spans exceed viewport dimensions

2 participants