Revert "[shared_preferences] Add shared preferences devtool" #8515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 258f6dc.
|
See #8494 (comment) for context. |
tarrinneal
approved these changes
Jan 28, 2025
tarrinneal
added
the
autosubmit
auto-submit
bot
deleted the
revert-8494-add-shared-preferences-devtool
branch
|
@stuartmorgan should I just open it again? Or are we going to revert the revert this time? |
The latter, as it says in this PR's description. |
🤦 Yes! My bad. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 28, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 28, 2025
flutter/packages@258f6dc...02c6fef 2025-01-28 stuartmorgan@google.com Revert "[shared_preferences] Add shared preferences devtool" (flutter/packages#8515) 2025-01-28 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Updates the internal wrapper to use `@ProxyApi` from pigeon (flutter/packages#8311) 2025-01-28 jhy03261997@gmail.com update the `const` in StatefulShellRouteData generation (flutter/packages#8502) 2025-01-27 pawel.jakubowski@leancode.pl [video_player_platform_interface] Platform view support (flutter/packages#8453) 2025-01-27 andrewrkolos@gmail.com [multicast_dns] Rewrite `_readFQDN` to avoid recursion (flutter/packages#8390) 2025-01-27 stuartmorgan@google.com [shared_preferences] Fix Android type mismatch regression (flutter/packages#8512) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…#8515) Reverts flutter#8494 This is a revert in order to reland (as a revert of this revert) now that the out-of-band failure in shared preferences is resolved, so that the package can go through the CI release process to ensure that the new tooling for pre-publish builds is working correctly.
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…8519) Re-lands flutter#8494 without changes, now that the unrelated failure is resolved. See flutter#8515 for context.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…#8515) Reverts flutter#8494 This is a revert in order to reland (as a revert of this revert) now that the out-of-band failure in shared preferences is resolved, so that the package can go through the CI release process to ensure that the new tooling for pre-publish builds is working correctly.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…8519) Re-lands flutter#8494 without changes, now that the unrelated failure is resolved. See flutter#8515 for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8494
This is a revert in order to reland (as a revert of this revert) now that the out-of-band failure in shared preferences is resolved, so that the package can go through the CI release process to ensure that the new tooling for pre-publish builds is working correctly.