[in_app_purchase_storekit] isIntroductoryOfferEligible implementation #9499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
givip
changed the title
givip
changed the title
..._app_purchase/in_app_purchase_storekit/lib/src/store_kit_2_wrappers/sk2_product_wrapper.dart
Show resolved
Hide resolved
...ages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform.dart
Show resolved
Hide resolved
...hase_storekit/Sources/in_app_purchase_storekit/StoreKit2/InAppPurchasePlugin+StoreKit2.swift
Outdated
Show resolved
Hide resolved
…kages into feature_isIntroductoryEligible
| isIntroductoryOfferEligibleChannel.setMessageHandler { message, reply in | ||
| let args = message as! [Any?] | ||
| let productIdArg = args[0] as! String | ||
| api.isIntroductoryOfferEligible(productId: productIdArg) { result in |
Contributor
There was a problem hiding this comment.
Hi @LouiseHsu it looks like the extension where isIntroductoryOfferEligible is defined has this availability annotation:
Does this mean if the developer's app's target iOS version is < 15.0 they'll get a compile time error from the plugin code (even if they're not using these new APIs at all?)
Contributor
There was a problem hiding this comment.
No, availability annotation on extensions will compile fine on lower device version, it just cannot reference any code inside that extension!
Contributor
There was a problem hiding this comment.
Ah it looks like the InAppPurchase2API calls are all placed inside an available check:
if #available(iOS 15.0, macOS 12.0, *) {
InAppPurchase2APISetup.setUp(binaryMessenger: messenger, api: instance)
}
So I guess if the application target's min iOS version is lower than 15 the caller would get a runtime error if they try to access methods defined in that extension, since the method channel is not set up?
LongCatIsLooong
approved these changes
Jul 2, 2025
...hase_storekit/Sources/in_app_purchase_storekit/StoreKit2/InAppPurchasePlugin+StoreKit2.swift
Outdated
Show resolved
Hide resolved
...ages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform.dart
Outdated
Show resolved
Hide resolved
…kages into feature_isIntroductoryEligible
Contributor
Author
|
@LouiseHsu could you check PR please? |
LouiseHsu
approved these changes
Jul 7, 2025
Contributor
LouiseHsu
left a comment
LouiseHsu
left a comment
There was a problem hiding this comment.
lgtm, sorry for the delay!
LouiseHsu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 7, 2025
flutter/packages@e4fd6c0...2c52f24 2025-07-07 pataridzegivi@gmail.com [in_app_purchase_storekit] isIntroductoryOfferEligible implementation (flutter/packages#9499) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…#171705) flutter/packages@e4fd6c0...2c52f24 2025-07-07 pataridzegivi@gmail.com [in_app_purchase_storekit] isIntroductoryOfferEligible implementation (flutter/packages#9499) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
…#171705) flutter/packages@e4fd6c0...2c52f24 2025-07-07 pataridzegivi@gmail.com [in_app_purchase_storekit] isIntroductoryOfferEligible implementation (flutter/packages#9499) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…flutter#9499) Added `isEligibleForIntroOffer` method support https://developer.apple.com/documentation/storekit/product/subscriptioninfo/iseligibleforintrooffer ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…#171705) flutter/packages@e4fd6c0...2c52f24 2025-07-07 pataridzegivi@gmail.com [in_app_purchase_storekit] isIntroductoryOfferEligible implementation (flutter/packages#9499) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
isEligibleForIntroOffermethod supporthttps://developer.apple.com/documentation/storekit/product/subscriptioninfo/iseligibleforintrooffer
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3